PlanHubMe/PlanHub

View on GitHub
emails.js

Summary

Maintainability
A
35 mins
Test Coverage

Function sendEmail has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

var sendEmail = function(templateName, to, templateObjs, done, err) {
Severity: Minor
Found in emails.js - About 35 mins to fix

    The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.
    Open

        for (var objIndex in objs) {
    Severity: Minor
    Found in emails.js by eslint

    Require Guarding for-in (guard-for-in)

    Looping over objects with a for in loop will include properties that are inherited through the prototype chain. This behavior can lead to unexpected items in your for loop.

    for (key in foo) {
        doSomething(key);
    }

    Note that simply checking foo.hasOwnProperty(key) is likely to cause an error in some cases; see [no-prototype-builtins](no-prototype-builtins.md).

    Rule Details

    This rule is aimed at preventing unexpected behavior that could arise from using a for in loop without filtering the results in the loop. As such, it will warn when for in loops do not filter their results with an if statement.

    Examples of incorrect code for this rule:

    /*eslint guard-for-in: "error"*/
    
    for (key in foo) {
        doSomething(key);
    }

    Examples of correct code for this rule:

    /*eslint guard-for-in: "error"*/
    
    for (key in foo) {
        if (Object.prototype.hasOwnProperty.call(foo, key)) {
            doSomething(key);
        }
        if ({}.hasOwnProperty.call(foo, key)) {
            doSomething(key);
        }
    }

    Related Rules

    • [no-prototype-builtins](no-prototype-builtins.md)

    Further Reading

    TODO found
    Open

            html: '<h1>MyHomeworkSpace</h1><h2>Verify your email</h2><p>TODO: some text here I guess</p><a href="(verify_url)">Click here to verify your email</a><p>If that didn\'t work, try copy-pasting the following URL into a new browser window: (verify_url)</p>',
    Severity: Minor
    Found in emails.js by fixme

    There are no issues that match your filters.

    Category
    Status