Playhi/FreezeYou

View on GitHub

Showing 285 of 313 total issues

Similar blocks of code found in 9 locations. Consider refactoring.
Open

            FUFSinglePackage.ERROR_INSUFFICIENT_PERMISSION -> {
                showPreProcessFUFResultAndShowToastAndReturnIfResultBelongsSuccess(
                    context, context.getString(R.string.insufficientPermission)
                )
                false
Severity: Major
Found in app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt and 8 other locations - About 30 mins to fix
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 637..642
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 643..648
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 649..654
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 662..667
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 668..673
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 674..679
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 680..685
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 692..697

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

            FUFSinglePackage.ERROR_NO_SUCH_API_MODE -> {
                showPreProcessFUFResultAndShowToastAndReturnIfResultBelongsSuccess(
                    context, context.getString(R.string.noSuchApiMode)
                )
                false
Severity: Major
Found in app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt and 8 other locations - About 30 mins to fix
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 637..642
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 643..648
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 649..654
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 662..667
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 668..673
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 680..685
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 686..691
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 692..697

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                        ToastUtils.showToast(
                            context,
                            context.getString(R.string.exceptionHC) + e.localizedMessage
                        )
Severity: Minor
Found in app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt and 1 other location - About 30 mins to fix
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 315..315

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                    if (originData != null
                            && !ILLEGALPKGNAME.equals(fromPkgLabel)
                            && MoreUtils.convertToList(originData, ",").contains(
                            Base64.encodeToString(fromPkgName.getBytes(), Base64.DEFAULT))) {
app/src/main/java/cf/playhi/freezeyou/ui/UriFreezeActivity.java on lines 137..143

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                ToastUtils.showToast(context, context.getString(R.string.exception) + e.message)
Severity: Minor
Found in app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt and 1 other location - About 30 mins to fix
app/src/main/java/cf/playhi/freezeyou/utils/FUFUtils.kt on lines 377..380

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 60.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language