QuickBlox/quickblox-javascript-sdk

View on GitHub
src/qbProxy.js

Summary

Maintainability
D
2 days
Test Coverage

Function ajax has a Cognitive Complexity of 54 (exceeds 5 allowed). Consider refactoring.
Open

    ajax: function(params, callback) {

        if (this._fetchingSettings) {
            this._queue.push([params, callback]);
            return;
Severity: Minor
Found in src/qbProxy.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ajax has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    ajax: function(params, callback) {

        if (this._fetchingSettings) {
            this._queue.push([params, callback]);
            return;
Severity: Major
Found in src/qbProxy.js - About 5 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                if (error || (statusCode !== 200 && statusCode !== 201 && statusCode !== 202)) {
                    var errorMsg;
    
                    try {
                        errorMsg = {
    Severity: Critical
    Found in src/qbProxy.js - About 4 hrs to fix

      Function _requestCallback has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              function _requestCallback(error, response, body) {
                  var statusCode = response && (response.status || response.statusCode),
                      responseMessage,
                      responseBody;
      
      
      Severity: Minor
      Found in src/qbProxy.js - About 1 hr to fix

        Function handleResponse has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            handleResponse: function(error, response, next, retry) {
                // can add middleware here...
                if (error) {
                    const errorMsg = JSON.stringify(error.message).toLowerCase();
                    if (typeof config.on.sessionExpired === 'function' &&
        Severity: Minor
        Found in src/qbProxy.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function startLogger has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            startLogger: function(params) {
                var clonedData;
        
                ++this.reqCount;
        
        
        Severity: Minor
        Found in src/qbProxy.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Redundant double negation.
        Open

                    if (!!session) {
        Severity: Minor
        Found in src/qbProxy.js by eslint

        disallow unnecessary boolean casts (no-extra-boolean-cast)

        In contexts such as an if statement's test where the result of the expression will already be coerced to a Boolean, casting to a Boolean via double negation (!!) or a Boolean call is unnecessary. For example, these if statements are equivalent:

        if (!!foo) {
            // ...
        }
        
        if (Boolean(foo)) {
            // ...
        }
        
        if (foo) {
            // ...
        }

        Rule Details

        This rule disallows unnecessary boolean casts.

        Examples of incorrect code for this rule:

        /*eslint no-extra-boolean-cast: "error"*/
        
        var foo = !!!bar;
        
        var foo = !!bar ? baz : bat;
        
        var foo = Boolean(!!bar);
        
        var foo = new Boolean(!!bar);
        
        if (!!foo) {
            // ...
        }
        
        if (Boolean(foo)) {
            // ...
        }
        
        while (!!foo) {
            // ...
        }
        
        do {
            // ...
        } while (Boolean(foo));
        
        for (; !!foo; ) {
            // ...
        }

        Examples of correct code for this rule:

        /*eslint no-extra-boolean-cast: "error"*/
        
        var foo = !!bar;
        var foo = Boolean(bar);
        
        function foo() {
            return !!bar;
        }
        
        var foo = bar ? !!baz : !!bat;

        Source: http://eslint.org/docs/rules/

        Unexpected console statement.
        Open

                    console.log('qbProxy fetch ... catch, error: ', error);
        Severity: Minor
        Found in src/qbProxy.js by eslint

        disallow the use of console (no-console)

        In JavaScript that is designed to be executed in the browser, it's considered a best practice to avoid using methods on console. Such messages are considered to be for debugging purposes and therefore not suitable to ship to the client. In general, calls using console should be stripped before being pushed to production.

        console.log("Made it here.");
        console.error("That shouldn't have happened.");

        Rule Details

        This rule disallows calls to methods of the console object.

        Examples of incorrect code for this rule:

        /*eslint no-console: "error"*/
        
        console.log("Log a debug level message.");
        console.warn("Log a warn level message.");
        console.error("Log an error level message.");

        Examples of correct code for this rule:

        /*eslint no-console: "error"*/
        
        // custom console
        Console.log("Hello world!");

        Options

        This rule has an object option for exceptions:

        • "allow" has an array of strings which are allowed methods of the console object

        Examples of additional correct code for this rule with a sample { "allow": ["warn", "error"] } option:

        /*eslint no-console: ["error", { allow: ["warn", "error"] }] */
        
        console.warn("Log a warn level message.");
        console.error("Log an error level message.");

        When Not To Use It

        If you're using Node.js, however, console is used to output information to the user and so is not strictly used for debugging purposes. If you are developing for Node.js then you most likely do not want this rule enabled.

        Related Rules

        There are no issues that match your filters.

        Category
        Status