Sign upLogin

RHeactorJS/web-app

View on GitHub
Star
js/controller/account-profile.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function AccountProfileController has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function AccountProfileController ($rootScope, $timeout, ClientStorageService, UserService) {
  const self = this
  self.user = false
  self.userCopy = false
  self.p = new HttpProgress()
Severity: Major
Found in js/controller/account-profile.js - About 2 hrs to fix

    Function AccountProfileController has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    export function AccountProfileController ($rootScope, $timeout, ClientStorageService, UserService) {
  const self = this
  self.user = false
  self.userCopy = false
  self.p = new HttpProgress()
    Severity: Minor
    Found in js/controller/account-profile.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateUserProperty has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      self.updateUserProperty = (property) => {
    if (self.e.$active) {
      return
    }
    if (self.userCopy[property] === self.user[property]) {
    Severity: Minor
    Found in js/controller/account-profile.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status