Sign upLogin

RITlug/teleirc

View on GitHub
Star

Showing 4 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func partHandler(c ClientInterface) func(*girc.Client, girc.Event) {
    return func(gc *girc.Client, e girc.Event) {
        c.Logger().LogDebug("partHandler triggered")
        if (e.Source != nil) && shouldSendLeave(c, e.Source.Name) {
            c.SendToTg(fmt.Sprintf(partFmt, e.Source.Name))
Severity: Major
Found in internal/handlers/irc/handlers.go and 1 other location - About 1 hr to fix
internal/handlers/irc/handlers.go on lines 145..152

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func joinHandler(c ClientInterface) func(*girc.Client, girc.Event) {
    return func(gc *girc.Client, e girc.Event) {
        c.Logger().LogDebug("joinHandler triggered")
        if (e.Source != nil) && shouldSendJoin(c, e.Source.Name) {
            c.SendToTg(fmt.Sprintf(joinFmt, e.Source.Name))
Severity: Major
Found in internal/handlers/irc/handlers.go and 1 other location - About 1 hr to fix
internal/handlers/irc/handlers.go on lines 154..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 150.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func shouldSendLeave(c ClientInterface, toCheck string) bool {
    var settings = c.TgSettings()
    if settings.ShowLeaveMessage {
        return true
    } else if settings.LeaveMessageAllowList == nil {
Severity: Minor
Found in internal/handlers/irc/handlers.go and 1 other location - About 40 mins to fix
internal/handlers/irc/handlers.go on lines 41..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func shouldSendJoin(c ClientInterface, toCheck string) bool {
    var settings = c.TgSettings()
    if settings.ShowJoinMessage {
        return true
    } else if settings.JoinMessageAllowList == nil {
Severity: Minor
Found in internal/handlers/irc/handlers.go and 1 other location - About 40 mins to fix
internal/handlers/irc/handlers.go on lines 57..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language