Similar blocks of code found in 2 locations. Consider refactoring. Open
<input className={css(styles.inputStyle)} name='password' type='password' key={3} onChange={e => props.onField2Change(e.target.value)} />
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 66.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
<input className={css(styles.inputStyle)} name='user' type='text' key={1} onChange={e => props.onField1Change(e.target.value)} />
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 66.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Unexpected unknown type selector "inputStyle" (selector-type-no-unknown) Open
inputStyle: {
- Read upRead up
- Exclude checks
selector-type-no-unknown
Disallow unknown type selectors.
<!-- prettier-ignore -->unknown {}
/** ↑
* This type selector */
This rule considers tags defined in the HTML, SVG, and MathML specifications to be known.
Unexpected unknown type selector "seperator2" (selector-type-no-unknown) Open
seperator2: { height: '7.5px' }
- Read upRead up
- Exclude checks
selector-type-no-unknown
Disallow unknown type selectors.
<!-- prettier-ignore -->unknown {}
/** ↑
* This type selector */
This rule considers tags defined in the HTML, SVG, and MathML specifications to be known.
Expected a trailing semicolon (declaration-block-trailing-semicolon) Open
seperator1: { height: '5px' },
- Read upRead up
- Exclude checks
declaration-block-trailing-semicolon
Require or disallow a trailing semicolon within declaration blocks.
<!-- prettier-ignore -->a { background: orange; color: pink; }
/** ↑
* This semicolon */
The trailing semicolon is the last semicolon in a declaration block and it is optional.
This rule ignores:
- Less mixins
- trailing
//
comments - declaration blocks containing nested (at-)rules
The [fix
option](../../../docs/user-guide/usage/options.md#fix) can automatically fix all of the problems reported by this rule.
Expected a trailing semicolon (declaration-block-trailing-semicolon) Open
paddingRight: '3px'
- Read upRead up
- Exclude checks
declaration-block-trailing-semicolon
Require or disallow a trailing semicolon within declaration blocks.
<!-- prettier-ignore -->a { background: orange; color: pink; }
/** ↑
* This semicolon */
The trailing semicolon is the last semicolon in a declaration block and it is optional.
This rule ignores:
- Less mixins
- trailing
//
comments - declaration blocks containing nested (at-)rules
The [fix
option](../../../docs/user-guide/usage/options.md#fix) can automatically fix all of the problems reported by this rule.
Expected "inputStyle" to be "inputstyle" (selector-type-case) Open
inputStyle: {
- Read upRead up
- Exclude checks
selector-type-case
Specify lowercase or uppercase for type selectors.
<!-- prettier-ignore -->a {}
/** ↑
* This is type selector */
The [fix
option](../../../docs/user-guide/usage/options.md#fix) can automatically fix all of the problems reported by this rule.
Unexpected unknown type selector "seperator1" (selector-type-no-unknown) Open
seperator1: { height: '5px' },
- Read upRead up
- Exclude checks
selector-type-no-unknown
Disallow unknown type selectors.
<!-- prettier-ignore -->unknown {}
/** ↑
* This type selector */
This rule considers tags defined in the HTML, SVG, and MathML specifications to be known.
Expected a trailing semicolon (declaration-block-trailing-semicolon) Open
seperator2: { height: '7.5px' }
- Read upRead up
- Exclude checks
declaration-block-trailing-semicolon
Require or disallow a trailing semicolon within declaration blocks.
<!-- prettier-ignore -->a { background: orange; color: pink; }
/** ↑
* This semicolon */
The trailing semicolon is the last semicolon in a declaration block and it is optional.
This rule ignores:
- Less mixins
- trailing
//
comments - declaration blocks containing nested (at-)rules
The [fix
option](../../../docs/user-guide/usage/options.md#fix) can automatically fix all of the problems reported by this rule.