RackHD/on-dhcp-proxy

View on GitHub

Showing 26 of 60 total issues

Function PacketFactory has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function PacketFactory(protocol, configuration, _) {
    var packetFunctions = {
        // Expose this for test
        createPacketBuffer: createPacketBuffer,
        createProxyDhcpAck: function(clientPacket, bootFileName) {
Severity: Minor
Found in lib/packet.js - About 1 hr to fix

    Function iscDhcpLeasePollerFactory has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        lookupService,
        configuration,
        Logger,
        Promise,
        assert,
    Severity: Major
    Found in lib/isc-dhcp-lease-poller.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

                  return 'monorail.ipxe';
      Severity: Major
      Found in lib/message-handler.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return 'monorail-undionly.kpxe';
        Severity: Major
        Found in lib/message-handler.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return 'monorail-efi64-snponly.efi';
          Severity: Major
          Found in lib/message-handler.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return 'monorail-efi32-snponly.efi';
            Severity: Major
            Found in lib/message-handler.js - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language