lib/message-handler.js
Function messageHandlerFactory
has 139 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
function messageHandlerFactory(
packetUtil,
parser,
lookupService,
configuration,
Function messageHandlerFactory
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
Open
function messageHandlerFactory(
packetUtil,
parser,
lookupService,
configuration,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function isBootFileNameSent
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
MessageHandler.prototype.isBootFileNameSent = function(packetData) {
var macAddress = packetData.chaddr.address;
return lookupService.macAddressToNode(macAddress)
.then(function(node) {
return node.discovered()
Function getDefaultBootfile
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
MessageHandler.prototype.getDefaultBootfile = function(packetData) {
assert.object(packetData);
assert.object(packetData.options);
assert.string(packetData.chaddr.address);
Function handleDhcpPacket
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
MessageHandler.prototype.handleDhcpPacket = function(packet, sendCallback) {
var self = this;
var packetData;
try {
Function messageHandlerFactory
has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
Open
packetUtil,
parser,
lookupService,
configuration,
taskProtocol,
Avoid too many return
statements within this function. Open
Open
return 'monorail-efi32-snponly.efi';
Avoid too many return
statements within this function. Open
Open
return 'monorail-undionly.kpxe';
Avoid too many return
statements within this function. Open
Open
return 'monorail-efi64-snponly.efi';
Avoid too many return
statements within this function. Open
Open
return 'monorail.ipxe';