Sign upLogin

RackHD/on-taskgraph

View on GitHub
Star
data/templates/bootstrap.js

Summary

Maintainability
C
1 day
Test Coverage

Function executeTasks has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function executeTasks(data, timeout) {
    var handleExecResult = function(_task, _done, error, stdout, stderr) {
        _task.stdout = stdout;
        _task.stderr = stderr;
        _task.error = error;
Severity: Minor
Found in data/templates/bootstrap.js - About 1 hr to fix

    Function updateTasks has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function updateTasks(data, timeout, retry, retries) {

    var request = http.request({
        hostname: server,
        port: port,
    Severity: Minor
    Found in data/templates/bootstrap.js - About 1 hr to fix

      Function getTasks has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getTasks(timeout) {
    http.request({
        hostname: server,
        port: port,
        path: tasksPath,
      Severity: Minor
      Found in data/templates/bootstrap.js - About 1 hr to fix

        Function eachSeries has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        function eachSeries(arr, iterator, callback) {
    callback = callback || function () {};

    if (!arr.length) {
        return callback();
        Severity: Minor
        Found in data/templates/bootstrap.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function executeTasks has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function executeTasks(data, timeout) {
    var handleExecResult = function(_task, _done, error, stdout, stderr) {
        _task.stdout = stdout;
        _task.stderr = stderr;
        _task.error = error;
        Severity: Minor
        Found in data/templates/bootstrap.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleExecResult has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            var handleExecResult = function(_task, _done, error, stdout, stderr) {
        Severity: Minor
        Found in data/templates/bootstrap.js - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          if (timeout) {
                    console.log("Sleeping " + timeout +
                                    " for Task Execution...");

                    setTimeout(function () {
          Severity: Major
          Found in data/templates/bootstrap.js and 1 other location - About 1 hr to fix
          data/templates/bootstrap.js on lines 216..224

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (timeout) {
            console.log("Sleeping " + timeout + " for Task Execution...");

            setTimeout(function () {
                getTasks(timeout);
          Severity: Major
          Found in data/templates/bootstrap.js and 1 other location - About 1 hr to fix
          data/templates/bootstrap.js on lines 201..210

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 61.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status