Sign upLogin

RackHD/on-taskgraph

View on GitHub
Star
lib/lease-expiration-poller.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function leaseExpirationPollerFactory has 62 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function leaseExpirationPollerFactory(
    store,
    Logger,
    assert,
    Constants,
Severity: Major
Found in lib/lease-expiration-poller.js - About 2 hrs to fix

    Function leaseExpirationPollerFactory has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        store,
    Logger,
    assert,
    Constants,
    Rx,
    Severity: Minor
    Found in lib/lease-expiration-poller.js - About 45 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          LeaseExpirationPoller.prototype.handleStreamError = function(msg, err) {
        logger.error(msg, {
            schedulerId: this.schedulerId,
            // stacks on some error objects (particularly from the assert library)
            // don't get printed if part of the error object so separate them out here.
      Severity: Major
      Found in lib/lease-expiration-poller.js and 2 other locations - About 2 hrs to fix
      lib/task-runner.js on lines 313..322
      lib/task-scheduler.js on lines 571..580

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          LeaseExpirationPoller.prototype.start = function() {
        this.running = true;
        this.pollTaskRunnerLeases();
    };
      Severity: Minor
      Found in lib/lease-expiration-poller.js and 1 other location - About 30 mins to fix
      lib/completed-task-poller.js on lines 280..283

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status