Sign upLogin

RackHD/on-taskgraph

View on GitHub
Star
lib/services/templates-api-service.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function templateApiServiceFactory has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function templateApiServiceFactory(
    Promise,
    workflowApiService,
    taskProtocol,
    eventsProtocol,
Severity: Major
Found in lib/services/templates-api-service.js - About 2 hrs to fix

    Function templateApiServiceFactory has 14 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        Promise,
    workflowApiService,
    taskProtocol,
    eventsProtocol,
    waterline,
    Severity: Major
    Found in lib/services/templates-api-service.js - About 1 hr to fix

      Function templateApiServiceFactory has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      function templateApiServiceFactory(
    Promise,
    workflowApiService,
    taskProtocol,
    eventsProtocol,
      Severity: Minor
      Found in lib/services/templates-api-service.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function templatesGetByName has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          TemplateApiService.prototype.templatesGetByName = function(req, res) {
        return Promise.resolve()
            .then(function() {
                var nodeId = req.query.nodeId;
                var macs = req.query.macs;
      Severity: Minor
      Found in lib/services/templates-api-service.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status