Sign upLogin

RackHD/on-tasks

View on GitHub
Star
lib/jobs/dell-wsman-bios.js

Summary

Maintainability
D
2 days
Test Coverage

Function DellWsmanBiosJobFactory has 115 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function DellWsmanBiosJobFactory(
    BaseJob,
    Logger,
    Promise,
    assert,
Severity: Major
Found in lib/jobs/dell-wsman-bios.js - About 4 hrs to fix

    Function DellWsmanBiosJobFactory has 12 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        BaseJob,
    Logger,
    Promise,
    assert,
    util,
    Severity: Major
    Found in lib/jobs/dell-wsman-bios.js - About 1 hr to fix

      Function handleAsyncResponse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          DellWsmanBiosJob.prototype.handleAsyncResponse = function(result, name) {
        var self = this;

        return Promise.resolve(result)
        .then(function() {
      Severity: Minor
      Found in lib/jobs/dell-wsman-bios.js - About 1 hr to fix

        Function _handleAsyncRequest has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            DellWsmanBiosJob.prototype._handleAsyncRequest = function() {
        var self = this;
        var type = '';
        if(self.inventories.length === 0){
            return self._done();
        Severity: Minor
        Found in lib/jobs/dell-wsman-bios.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      return waterline.catalogs.findLatestCatalogOfSource(self.nodeId, name)
            .then(function(catalog){
                if (_.isEmpty(catalog)) {
                    logger.debug("handleAsyncResponse: Catalog (" + name + ") not found.  Creating...");
                    return waterline.catalogs.create({
          Severity: Major
          Found in lib/jobs/dell-wsman-bios.js and 1 other location - About 5 hrs to fix
          lib/jobs/dell-wsman-inventory.js on lines 163..176

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 152.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              function DellWsmanBiosJob(options, context, taskId) {
        DellWsmanBiosJob.super_.call(this,
                                   logger,
                                   options,
                                   context,
          Severity: Major
          Found in lib/jobs/dell-wsman-bios.js and 1 other location - About 3 hrs to fix
          lib/jobs/dell-wsman-get-trap-config.js on lines 44..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                          self.target = {
                    address: ipAddr,
                    userName: obm.config.user,
                    password: encryption.decrypt(obm.config.password)
                };
          Severity: Minor
          Found in lib/jobs/dell-wsman-bios.js and 1 other location - About 50 mins to fix
          lib/jobs/dell-wsman-get-trap-config.js on lines 85..89

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                      self.wsman = new WsmanTool(self.dellConfigs.gateway, {
                verifySSL: self.options.verifySSL || false,
                recvTimeoutMs: 300000
            });
          Severity: Minor
          Found in lib/jobs/dell-wsman-bios.js and 2 other locations - About 35 mins to fix
          lib/jobs/dell-wsman-get-trap-config.js on lines 76..79
          lib/jobs/dell-wsman-inventory.js on lines 73..76

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status