Sign upLogin

RackHD/on-tasks

View on GitHub
Star
lib/jobs/dell-wsman-inventory.js

Summary

Maintainability
D
2 days
Test Coverage

Function DellWsmanInventoryJobFactory has 127 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function DellWsmanInventoryJobFactory(
    BaseJob,
    Logger,
    Promise,
    util,
Severity: Major
Found in lib/jobs/dell-wsman-inventory.js - About 5 hrs to fix

    Function _handleAsyncRequest has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

         DellWsmanInventoryJob.prototype._handleAsyncRequest = function() {
          var self = this;
          var type = '';
          if(self.inventories.length === 0){
              logger.info('Completed INVENTORY collection for (' + self.nodeType + ') node: ' + self.nodeId);
    Severity: Minor
    Found in lib/jobs/dell-wsman-inventory.js - About 1 hr to fix

      Function DellWsmanInventoryJobFactory has 11 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          BaseJob,
    Logger,
    Promise,
    util,
    waterline,
      Severity: Major
      Found in lib/jobs/dell-wsman-inventory.js - About 1 hr to fix

        Function handleAsyncResponse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            DellWsmanInventoryJob.prototype.handleAsyncResponse = function(result, name) {
        var self = this;

        return Promise.resolve(result)
        .then(function() {
        Severity: Minor
        Found in lib/jobs/dell-wsman-inventory.js - About 1 hr to fix

          Function DellWsmanInventoryJobFactory has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          function DellWsmanInventoryJobFactory(
    BaseJob,
    Logger,
    Promise,
    util,
          Severity: Minor
          Found in lib/jobs/dell-wsman-inventory.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _initJob has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              DellWsmanInventoryJob.prototype._initJob = function () {
        var self = this;
        return self.checkOBM('Inventory')
        .then(function(obm) {
            self.dellConfigs = configuration.get('dell');
          Severity: Minor
          Found in lib/jobs/dell-wsman-inventory.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        return waterline.catalogs.findLatestCatalogOfSource(self.nodeId, name)
            .then(function(catalog){
                if (_.isEmpty(catalog)) {
                    logger.debug("handleAsyncResponse: Catalog (" + name + ") not found.  Creating...");
                    return waterline.catalogs.create({
            Severity: Major
            Found in lib/jobs/dell-wsman-inventory.js and 1 other location - About 5 hrs to fix
            lib/jobs/dell-wsman-bios.js on lines 156..169

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                        self.wsman = new WsmanTool(self.dellConfigs.gateway, {
                verifySSL: self.options.verifySSL || false,
                recvTimeoutMs: 300000
            });
            Severity: Minor
            Found in lib/jobs/dell-wsman-inventory.js and 2 other locations - About 35 mins to fix
            lib/jobs/dell-wsman-bios.js on lines 78..81
            lib/jobs/dell-wsman-get-trap-config.js on lines 76..79

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status