Sign upLogin

RackHD/on-tasks

View on GitHub
Star
lib/jobs/general-redfish-catalog.js

Summary

Maintainability
F
5 days
Test Coverage

Function GeneralRedfishCatalogJobFactory has 355 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function GeneralRedfishCatalogJobFactory(
    eventsProtocol,
    BaseJob,
    Logger,
    Promise,
Severity: Major
Found in lib/jobs/general-redfish-catalog.js - About 1 day to fix

    File general-redfish-catalog.js has 387 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //Copyright 2017, Dell EMC, Inc.
'use strict';

var di = require('di');
var request = require('requestretry');
    Severity: Minor
    Found in lib/jobs/general-redfish-catalog.js - About 5 hrs to fix

      Function replacer has 111 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          GeneralRedfishCatalogJob.prototype.replacer = function(nodeId, odataId, res) {
        var self = this;

        var catalogString = JSON.stringify(res.body);
        var odataIdString = odataId;
      Severity: Major
      Found in lib/jobs/general-redfish-catalog.js - About 4 hrs to fix

        Function GeneralRedfishCatalogJobFactory has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

        function GeneralRedfishCatalogJobFactory(
    eventsProtocol,
    BaseJob,
    Logger,
    Promise,
        Severity: Minor
        Found in lib/jobs/general-redfish-catalog.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function catalogEndpoints has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            GeneralRedfishCatalogJob.prototype.catalogEndpoints = Promise.method(function(nodeId) {
        var self = this;
        if (nodeId === undefined)
        {
            return;
        Severity: Minor
        Found in lib/jobs/general-redfish-catalog.js - About 1 hr to fix

          Function driveEndpoints has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              GeneralRedfishCatalogJob.prototype.driveEndpoints = Promise.method(function(nodeId) {
        var self = this;
    var redfish = new RedfishTool();
        return redfish.setup(nodeId)
            .then(function() {
          Severity: Minor
          Found in lib/jobs/general-redfish-catalog.js - About 1 hr to fix

            Function GeneralRedfishCatalogJobFactory has 11 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                eventsProtocol,
    BaseJob,
    Logger,
    Promise,
    assert,
            Severity: Major
            Found in lib/jobs/general-redfish-catalog.js - About 1 hr to fix

              Function createRedfishCatalogs has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  GeneralRedfishCatalogJob.prototype.createRedfishCatalogs = function (odataId, nodeId) {
        var self = this;

        if (self.processedOdataIds[nodeId] === undefined) {
            self.processedOdataIds[nodeId] = {};
              Severity: Minor
              Found in lib/jobs/general-redfish-catalog.js - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        .then(function(settings) {
            var url = settings.protocol + '://' + settings.host + ':' + settings.port + path;
            return request.get(url, {
                'auth': {
                    'user': settings.username || '',
                Severity: Major
                Found in lib/jobs/general-redfish-catalog.js and 1 other location - About 3 hrs to fix
                lib/jobs/redfish-discovery-list.js on lines 74..85

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 98.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                        return redfish.setup(nodeId)
            .then(function() {
                return self.restRequest(nodeId, redfish.settings.root);
            })
            .then(function (res) {
                Severity: Major
                Found in lib/jobs/general-redfish-catalog.js and 5 other locations - About 1 hr to fix
                lib/jobs/emc-redfish-catalog.js on lines 77..149
                lib/jobs/general-redfish-catalog.js on lines 327..345
                lib/jobs/general-redfish-catalog.js on lines 367..384
                lib/jobs/general-redfish-catalog.js on lines 413..429
                lib/jobs/general-redfish-catalog.js on lines 403..442

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                        return redfish.setup(nodeId)
            .then(function() {
                var beforeSettings = redfish.settings.root;
                var redfishSettings = beforeSettings.replace('Chassis', 'Systems');
                return self.restRequest(nodeId, redfishSettings);
                Severity: Major
                Found in lib/jobs/general-redfish-catalog.js and 5 other locations - About 1 hr to fix
                lib/jobs/emc-redfish-catalog.js on lines 77..149
                lib/jobs/general-redfish-catalog.js on lines 327..345
                lib/jobs/general-redfish-catalog.js on lines 367..384
                lib/jobs/general-redfish-catalog.js on lines 356..397
                lib/jobs/general-redfish-catalog.js on lines 413..429

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                        return redfish.setup(nodeId)
            .then(function () {
                var beforeSettings = redfish.settings.root;
                var redfishSettings = beforeSettings.replace('Chassis', 'Systems');
                return self.createRedfishCatalogs(redfishSettings, nodeId);
                Severity: Major
                Found in lib/jobs/general-redfish-catalog.js and 5 other locations - About 1 hr to fix
                lib/jobs/emc-redfish-catalog.js on lines 77..149
                lib/jobs/general-redfish-catalog.js on lines 367..384
                lib/jobs/general-redfish-catalog.js on lines 356..397
                lib/jobs/general-redfish-catalog.js on lines 413..429
                lib/jobs/general-redfish-catalog.js on lines 403..442

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                                            return self.restRequest(nodeId, path)
                                .then(function (data) {

                                    return self.replacer(nodeId, data.body['@odata.id'], data)
                                    .then(function () {
                Severity: Major
                Found in lib/jobs/general-redfish-catalog.js and 5 other locations - About 1 hr to fix
                lib/jobs/emc-redfish-catalog.js on lines 77..149
                lib/jobs/general-redfish-catalog.js on lines 327..345
                lib/jobs/general-redfish-catalog.js on lines 356..397
                lib/jobs/general-redfish-catalog.js on lines 413..429
                lib/jobs/general-redfish-catalog.js on lines 403..442

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 6 locations. Consider refactoring.
                Open

                                            return self.restRequest(nodeId, driveElem['@odata.id'])
                                .then(function (data) {
                                    return self.replacer(nodeId, data.body['@odata.id'], data)
                                    .then(function () {
                                        return nodeId;
                Severity: Major
                Found in lib/jobs/general-redfish-catalog.js and 5 other locations - About 1 hr to fix
                lib/jobs/emc-redfish-catalog.js on lines 77..149
                lib/jobs/general-redfish-catalog.js on lines 327..345
                lib/jobs/general-redfish-catalog.js on lines 367..384
                lib/jobs/general-redfish-catalog.js on lines 356..397
                lib/jobs/general-redfish-catalog.js on lines 403..442

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 59.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status