Sign upLogin

RackHD/on-tasks

View on GitHub
Star
lib/jobs/ipmi-job.js

Summary

Maintainability
F
4 days
Test Coverage

Function ipmiJobFactory has 293 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function ipmiJobFactory(
    BaseJob,
    ipmitool,
    parser,
    Logger,
Severity: Major
Found in lib/jobs/ipmi-job.js - About 1 day to fix

    Function collectIpmiSelEntries has 118 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        IpmiJob.prototype.collectIpmiSelEntries = function(data) {
        var self = this;
        var lastPreviouslyReadSelEntry;
        var lastSelDeleteTimeCurrent, lastSelDeleteTimeLastRun;
        var totalEntries;
    Severity: Major
    Found in lib/jobs/ipmi-job.js - About 4 hrs to fix

      File ipmi-job.js has 326 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // Copyright 2015, EMC, Inc.

'use strict';

var di = require('di');
      Severity: Minor
      Found in lib/jobs/ipmi-job.js - About 3 hrs to fix

        Function ipmiJobFactory has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

        function ipmiJobFactory(
    BaseJob,
    ipmitool,
    parser,
    Logger,
        Severity: Minor
        Found in lib/jobs/ipmi-job.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createCallback has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            IpmiJob.prototype.createCallback = function(cmd, ipmiCallBack) {
        var self = this;
        function genericCallback(data) {
            if (!data.host || !data.user || !data.password) {
                return;
        Severity: Minor
        Found in lib/jobs/ipmi-job.js - About 1 hr to fix

          Function genericCallback has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  function genericCallback(data) {
            if (!data.host || !data.user || !data.password) {
                return;
            }
            if (self.concurrentRequests(data.host, cmd)) {
          Severity: Minor
          Found in lib/jobs/ipmi-job.js - About 1 hr to fix

            Function ipmiJobFactory has 12 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                BaseJob,
    ipmitool,
    parser,
    Logger,
    util,
            Severity: Major
            Found in lib/jobs/ipmi-job.js - About 1 hr to fix

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                              return waterline.workitems.findOne({ id: data.workItemId })
                .then(function(workitem) {
                    return pollerHelper.getNodeAlertMsg(workitem.node, workitem.state,
                        "inaccessible")
                    .tap(function(message){
              Severity: Major
              Found in lib/jobs/ipmi-job.js and 1 other location - About 2 hrs to fix
              lib/jobs/snmp-job.js on lines 156..162

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 91.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  IpmiJob.prototype.addConcurrentRequest = function(host, type) {
        assert.object(this.concurrent[host]);
        assert.number(this.concurrent[host][type]);
        this.concurrent[host][type] += 1;
    };
              Severity: Major
              Found in lib/jobs/ipmi-job.js and 2 other locations - About 2 hrs to fix
              lib/jobs/redfish-job.js on lines 153..157
              lib/jobs/redfish-job.js on lines 163..167

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 87.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  IpmiJob.prototype.collectIpmiSelInformation = function(data) {
        return ipmitool.selInformation(data.host, data.user, data.password)
        .then(function (sel) {
            return parser.parseSelInformationData(sel);
        });
              Severity: Major
              Found in lib/jobs/ipmi-job.js and 1 other location - About 1 hr to fix
              lib/jobs/ipmi-job.js on lines 461..466

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  IpmiJob.prototype.collectIpmiDriveHealth = function(data) {
        return ipmitool.driveHealthStatus(data.host, data.user, data.password)
        .then(function (status) {
            return parser.parseDriveHealthData(status);
        });
              Severity: Major
              Found in lib/jobs/ipmi-job.js and 1 other location - About 1 hr to fix
              lib/jobs/ipmi-job.js on lines 188..193

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 70.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status