Sign upLogin

RackHD/on-tasks

View on GitHub
Star
lib/task.js

Summary

Maintainability
F
6 days
Test Coverage

Function factory has 453 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function factory(
    configuration,
    Logger,
    assert,
    Errors,
Severity: Major
Found in lib/task.js - About 2 days to fix

    Function factory has a Cognitive Complexity of 95 (exceeds 5 allowed). Consider refactoring.
    Open

    function factory(
    configuration,
    Logger,
    assert,
    Errors,
    Severity: Minor
    Found in lib/task.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File task.js has 494 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright 2015, EMC, Inc.

'use strict';

var di = require('di');
    Severity: Minor
    Found in lib/task.js - About 7 hrs to fix

      Function Task has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function Task(definition, taskOverrides, context) {
        var self = this;
        assert.object(context, 'Task shared context object');

        self.definition = _.cloneDeep(definition);
      Severity: Major
      Found in lib/task.js - About 2 hrs to fix

        Function run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            Task.prototype.run = function() {
        var self = this;
        if (self.state !== TaskStates.Pending) {
            return Promise.resolve();
        }
        Severity: Major
        Found in lib/task.js - About 2 hrs to fix

          Function factory has 15 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              configuration,
    Logger,
    assert,
    Errors,
    Constants,
          Severity: Major
          Found in lib/task.js - About 1 hr to fix

            Function render has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                Task.prototype.render = function(source, context, depth) {
        var self = this;

        var parsed = self.parse(source);
        // use original hogan render while source contains complex logic like iteration
            Severity: Minor
            Found in lib/task.js - About 1 hr to fix

              Function renderString has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  Task.prototype.renderString = function(str, context, depth, maxDepth) {
        var self = this;

        if (depth > maxDepth) {
            throw new Errors.TemplateRenderError("Exceeded max depth rendering string: " + str);
              Severity: Minor
              Found in lib/task.js - About 1 hr to fix

                Function validateOptions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    Task.validateOptions = function (definition, options, flags) {
        var jobSchema;

        //if the definition is from taskgraph, then the taskgraph has helped to assigned the
        //joOptionsSchema, so it's uncessary to lookup the baseTask again
                Severity: Minor
                Found in lib/task.js - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          var obj = _.transform(this, function(result, v, k) {
            if (!_.contains(redactKeys, k)) {
                result[k] = v;
            }
        }, {});
                  Severity: Minor
                  Found in lib/task.js and 1 other location - About 40 mins to fix
                  lib/jobs/base-job.js on lines 156..160

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 49.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status