Sign upLogin

RackHD/on-tasks

View on GitHub
Star
lib/utils/metrics/snmp-pdu-power-status.js

Summary

Maintainability
F
3 days
Test Coverage

Function snmpPduPowerMetricFactory has 254 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function snmpPduPowerMetricFactory(
    BaseMetric,
    assert,
    util,
    _,
Severity: Major
Found in lib/utils/metrics/snmp-pdu-power-status.js - About 1 day to fix

    Function _calculateSineticaPowerData has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        SnmpPduPowerMetric.prototype._calculateSineticaPowerData = function(powerData) {
        var out = {};
        var unitsMap = { 
            'pduOutName': 'null',
            'pduOutOn': 'null',
    Severity: Major
    Found in lib/utils/metrics/snmp-pdu-power-status.js - About 4 hrs to fix

      File snmp-pdu-power-status.js has 284 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      // Copyright 2015, EMC, Inc.

'use strict';

var di = require('di');
      Severity: Minor
      Found in lib/utils/metrics/snmp-pdu-power-status.js - About 2 hrs to fix

        Function calculatePowerData has 56 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            SnmpPduPowerMetric.prototype.calculatePowerData = function(values) {
        var self = this;
        if (this.nodeType === 'sinetica') {
            return Promise.resolve(self._calculateSineticaPowerData(values))
            .then(function(results) {
        Severity: Major
        Found in lib/utils/metrics/snmp-pdu-power-status.js - About 2 hrs to fix

          Function _collectSineticaPowerData has 52 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              SnmpPduPowerMetric.prototype._collectSineticaPowerData = function() {
        var self = this;
         var snmpQueryType = 'bulkwalk';

        // NOTE: Sinetica(Panduit) IPI PDU gateway cannot handle snmp commands concurrently
          Severity: Major
          Found in lib/utils/metrics/snmp-pdu-power-status.js - About 2 hrs to fix

            Function snmpPduPowerMetricFactory has 10 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                BaseMetric,
    assert,
    util,
    _,
    Promise,
            Severity: Major
            Found in lib/utils/metrics/snmp-pdu-power-status.js - About 1 hr to fix

              Function snmpPduPowerMetricFactory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              function snmpPduPowerMetricFactory(
    BaseMetric,
    assert,
    util,
    _,
              Severity: Minor
              Found in lib/utils/metrics/snmp-pdu-power-status.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      var lastResults = _(cache)
                        .map(function(pdu) {
                            var outlets = pdu.outlets || [];
                            return _.map(outlets, function(outlet) {
                                return outlet;
              Severity: Major
              Found in lib/utils/metrics/snmp-pdu-power-status.js and 1 other location - About 2 hrs to fix
              lib/utils/metrics/snmp-pdu-power-status.js on lines 82..91

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 84.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      var currentResults = _(results)
                        .map(function(pdu) {
                            var outlets = pdu.outlets || [];
                            return _.map(outlets, function(outlet) {
                                return outlet;
              Severity: Major
              Found in lib/utils/metrics/snmp-pdu-power-status.js and 1 other location - About 2 hrs to fix
              lib/utils/metrics/snmp-pdu-power-status.js on lines 71..80

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 84.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status