Sign upLogin

RackHD/on-tftp

View on GitHub
Star
lib/server.js

Summary

Maintainability
C
1 day
Test Coverage

Function TftpServerFactory has 114 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function TftpServerFactory(
    Logger,
    configuration,
    eventsProtocol,
    lookupService,
Severity: Major
Found in lib/server.js - About 4 hrs to fix

    Function handleRequest has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        Tftp.prototype.handleRequest = function(req, res){
        req._startAt = process.hrtime();

        req.on("error", function() {
            logger.warning("Tftp error", {
    Severity: Minor
    Found in lib/server.js - About 1 hr to fix

      Function TftpServerFactory has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          Logger,
    configuration,
    eventsProtocol,
    lookupService,
    FileLoader,
      Severity: Major
      Found in lib/server.js - About 50 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                req.on("abort", function() {
            logger.warning("Tftp abort", {
                file: req.file,
                remoteAddress: req.stats.remoteAddress,
                remotePort: req.stats.remotePort,
        Severity: Major
        Found in lib/server.js and 1 other location - About 1 hr to fix
        lib/server.js on lines 87..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                req.on("error", function() {
            logger.warning("Tftp error", {
                file: req.file,
                remoteAddress: req.stats.remoteAddress,
                remotePort: req.stats.remotePort,
        Severity: Major
        Found in lib/server.js and 1 other location - About 1 hr to fix
        lib/server.js on lines 126..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 74.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status