RailsStudyGroup/redditgraphed

View on GitHub
app/assets/javascripts/toastr.js

Summary

Maintainability
D
1 day
Test Coverage

Function notify has 131 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function notify(map) {
var options = getOptions(),
iconClass = map.iconClass || options.iconClass;
if (options.preventDuplicates) {
if (map.message === previousToast) {
Severity: Major
Found in app/assets/javascripts/toastr.js - About 5 hrs to fix

    File toastr.js has 314 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
    * Toastr
    * Copyright 2012-2014
    * Authors: John Papa, Hans FjÀllemark, and Tim Ferrell.
    * All Rights Reserved.
    Severity: Minor
    Found in app/assets/javascripts/toastr.js - About 3 hrs to fix

      Function getDefaults has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function getDefaults() {
      return {
      tapToDismiss: true,
      toastClass: 'toast',
      containerId: 'toast-container',
      Severity: Minor
      Found in app/assets/javascripts/toastr.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        function warning(message, title, optionsOverride) {
        return notify({
        type: toastType.warning,
        iconClass: getOptions().iconClasses.warning,
        message: message,
        Severity: Major
        Found in app/assets/javascripts/toastr.js and 2 other locations - About 1 hr to fix
        app/assets/javascripts/toastr.js on lines 60..68
        app/assets/javascripts/toastr.js on lines 72..80

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        function info(message, title, optionsOverride) {
        return notify({
        type: toastType.info,
        iconClass: getOptions().iconClasses.info,
        message: message,
        Severity: Major
        Found in app/assets/javascripts/toastr.js and 2 other locations - About 1 hr to fix
        app/assets/javascripts/toastr.js on lines 72..80
        app/assets/javascripts/toastr.js on lines 81..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        function success(message, title, optionsOverride) {
        return notify({
        type: toastType.success,
        iconClass: getOptions().iconClasses.success,
        message: message,
        Severity: Major
        Found in app/assets/javascripts/toastr.js and 2 other locations - About 1 hr to fix
        app/assets/javascripts/toastr.js on lines 60..68
        app/assets/javascripts/toastr.js on lines 81..89

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        if (map.title) {
        $titleElement.append(map.title).addClass(options.titleClass);
        $toastElement.append($titleElement);
        }
        Severity: Minor
        Found in app/assets/javascripts/toastr.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/toastr.js on lines 215..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        if (map.message) {
        $messageElement.append(map.message).addClass(options.messageClass);
        $toastElement.append($messageElement);
        }
        Severity: Minor
        Found in app/assets/javascripts/toastr.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/toastr.js on lines 211..214

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status