RedHatInsights/insights-rbac-ui

View on GitHub
src/presentational-components/shared/toolbar.js

Summary

Maintainability
C
1 day
Test Coverage

File toolbar.js has 363 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import PrimaryToolbar from '@redhat-cloud-services/frontend-components/PrimaryToolbar';
import { useIntl } from 'react-intl';
import PropTypes from 'prop-types';
import messages from '../../Messages';
Severity: Minor
Found in src/presentational-components/shared/toolbar.js - About 4 hrs to fix

    Function activeFiltersConfigBuilder has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

    export const activeFiltersConfigBuilder = (
      filterValue = '',
      filters,
      pagination = {},
      setFilterValue = () => undefined,
    Severity: Minor
    Found in src/presentational-components/shared/toolbar.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function filterConfigBuilder has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    export const filterConfigBuilder = (
      isLoading,
      setFilterValue = () => undefined,
      fetchData = () => undefined,
      filterValue = '',
    Severity: Minor
    Found in src/presentational-components/shared/toolbar.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onChange has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                  onChange: (_e, filterBy) => {
                    const newFilter =
                      typeof filterBy !== 'string' && !Array.isArray(filterBy) ? Object.keys(pickBy(filterBy[''], (value) => value)) : filterBy;
    
                    setFilterValue({
    Severity: Minor
    Found in src/presentational-components/shared/toolbar.js - About 1 hr to fix

      Function onDelete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        onDelete: (_e, [deleted], isAll) => {
          const setKeyValue = (value, type, key) => {
            if (isAll) {
              return type === 'group' || type === 'checkbox' ? [] : '';
            }
      Severity: Minor
      Found in src/presentational-components/shared/toolbar.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status