RedHatInsights/insights-rbac-ui

View on GitHub
src/smart-components/role/add-role/cost-resources.js

Summary

Maintainability
C
1 day
Test Coverage

Function CostResources has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const CostResources = (props) => {
  const intl = useIntl();
  const dispatch = useDispatch();
  const fetchData = (apiProps) => dispatch(fetchResourceDefinitions(apiProps));
  const getResource = (apiProps) => dispatch(fetchResource(apiProps));
Severity: Major
Found in src/smart-components/role/add-role/cost-resources.js - About 4 hrs to fix

    Function reducer has 56 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const reducer = (state, action) => {
      const prevState = state[action.key];
      switch (action.type) {
        case 'toggle':
          return {
    Severity: Major
    Found in src/smart-components/role/add-role/cost-resources.js - About 2 hrs to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            <GridItem md={8} className="rbac-m-hide-on-sm">
              <Text component={TextVariants.h4} className="rbac-bold-text">
                {intl.formatMessage(messages.resourceDefinitions)}
              </Text>
            </GridItem>
      Severity: Major
      Found in src/smart-components/role/add-role/cost-resources.js and 2 other locations - About 1 hr to fix
      src/smart-components/role/add-role/cost-resources.js on lines 184..188
      src/smart-components/role/add-role/inventory-groups-role.js on lines 330..334

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            <GridItem md={4} className="rbac-m-hide-on-sm">
              <Text component={TextVariants.h4} className="rbac-bold-text">
                {intl.formatMessage(messages.permissions)}
              </Text>
            </GridItem>
      Severity: Major
      Found in src/smart-components/role/add-role/cost-resources.js and 2 other locations - About 1 hr to fix
      src/smart-components/role/add-role/cost-resources.js on lines 189..193
      src/smart-components/role/add-role/inventory-groups-role.js on lines 330..334

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const permissions = formOptions.getState().values['add-permissions-table'].filter(({ uuid }) => uuid.split(':')[0].includes('cost-management'));
      Severity: Minor
      Found in src/smart-components/role/add-role/cost-resources.js and 1 other location - About 55 mins to fix
      src/smart-components/role/add-role/inventory-groups-role.js on lines 134..136

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status