Sign upLogin

RedHatInsights/insights-rbac-ui

View on GitHub
Star
src/smart-components/role/add-role/inventory-groups-role.js

Summary

Maintainability
F
3 days
Test Coverage

Function InventoryGroupsRole has 205 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const InventoryGroupsRole = (props) => {
  const intl = useIntl();
  const dispatch = useDispatch();
  const { input } = useFieldApi(props);
  const formOptions = useFormApi();
Severity: Major
Found in src/smart-components/role/add-role/inventory-groups-role.js - About 1 day to fix

    Function InventoryGroupsRole has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    const InventoryGroupsRole = (props) => {
  const intl = useIntl();
  const dispatch = useDispatch();
  const { input } = useFieldApi(props);
  const formOptions = useFormApi();
    Severity: Minor
    Found in src/smart-components/role/add-role/inventory-groups-role.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File inventory-groups-role.js has 328 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { useEffect, useReducer } from 'react';
import {
  Button,
  Grid,
  GridItem,
    Severity: Minor
    Found in src/smart-components/role/add-role/inventory-groups-role.js - About 3 hrs to fix

      Function reducer has 81 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const reducer = (state, action) => {
  const prevState = state[action.key];
  switch (action.type) {
    case 'toggle':
      return {
      Severity: Major
      Found in src/smart-components/role/add-role/inventory-groups-role.js - About 3 hrs to fix

        Function makeRow has 79 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const makeRow = (permissionID, index) => {
    const options = Object.values(resourceTypes?.[permissionID] ?? {});

    return (
      <React.Fragment key={permissionID}>
        Severity: Major
        Found in src/smart-components/role/add-role/inventory-groups-role.js - About 3 hrs to fix

          Function reducer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          const reducer = (state, action) => {
  const prevState = state[action.key];
  switch (action.type) {
    case 'toggle':
      return {
          Severity: Minor
          Found in src/smart-components/role/add-role/inventory-groups-role.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                <GridItem md={3} className="rbac-m-hide-on-sm">
        <Text component={TextVariants.h4} className="rbac-bold-text pf-v5-u-mt-sm">
          {intl.formatMessage(messages.permissions)}
        </Text>
      </GridItem>
          Severity: Major
          Found in src/smart-components/role/add-role/inventory-groups-role.js and 2 other locations - About 1 hr to fix
          src/smart-components/role/add-role/cost-resources.js on lines 184..188
          src/smart-components/role/add-role/cost-resources.js on lines 189..193

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              formOptions
      .getState()
      .values['add-permissions-table'].filter(({ uuid }) => uuid.split(':')[0].includes('inventory'))
          Severity: Minor
          Found in src/smart-components/role/add-role/inventory-groups-role.js and 1 other location - About 55 mins to fix
          src/smart-components/role/add-role/cost-resources.js on lines 86..86

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status