Sign upLogin

Restream/redmine_digest

View on GitHub
Star

Showing 14 of 16 total issues

Method format_other_attr has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def format_other_attr(val)
    case journal_detail.property
      when 'attr'
        field = journal_detail.prop_key.to_s.gsub(/_id$/, '')
        case journal_detail.prop_key
Severity: Minor
Found in app/models/digest_event/base.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Digest has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Digest
    # batch size for fetching issues
    ISSUE_BATCH_SIZE = 300

    attr_reader :digest_rule, :time_to
Severity: Minor
Found in lib/redmine_digest/digest.rb - About 3 hrs to fix

    Method projects_tree_for_selector has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def projects_tree_for_selector(projects, options = {})
    result = []
    projects.each do |project|

      children      = project.cached_children.sort
    Severity: Minor
    Found in app/helpers/digest_rules_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_digest_issue_with_events has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def get_digest_issue_with_events(issue)
      d_issue = DigestIssue.new(
        id:              issue.id,
        subject:         issue.subject,
        status_id:       issue.status_id,
    Severity: Minor
    Found in lib/redmine_digest/digest.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method get_digest_issue_with_events has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def get_digest_issue_with_events(issue)
      d_issue = DigestIssue.new(
        id:              issue.id,
        subject:         issue.subject,
        status_id:       issue.status_id,
    Severity: Minor
    Found in lib/redmine_digest/digest.rb - About 1 hr to fix

      Method format_other_attr has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def format_other_attr(val)
    case journal_detail.property
      when 'attr'
        field = journal_detail.prop_key.to_s.gsub(/_id$/, '')
        case journal_detail.prop_key
      Severity: Minor
      Found in app/models/digest_event/base.rb - About 1 hr to fix

        Method fetch_issues has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def fetch_issues
      raise 'DigestRule#user must be filled' if user.nil?

      d_issues = []
        Severity: Minor
        Found in lib/redmine_digest/digest.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method new_event has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def self.new_event(event_type, issue_id, created_on, user, journal = nil, journal_detail = nil)
        Severity: Minor
        Found in app/models/digest_event_factory.rb - About 45 mins to fix

          Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def initialize(event_type, issue_id, created_on, user, journal = nil, journal_detail = nil)
          Severity: Minor
          Found in app/models/digest_event/base.rb - About 45 mins to fix

            Method find_events_by_journal has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def find_events_by_journal(journal)
    return [] unless affected_project_ids.include?(journal.issue.project_id)

    events = []
            Severity: Minor
            Found in app/models/digest_rule.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method notified_events? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def notified_events?(journal)
      Setting.notified_events.include?('issue_updated') ||
        (Setting.notified_events.include?('issue_note_added') && journal.notes.present?) ||
        (Setting.notified_events.include?('issue_status_updated') && journal.new_status.present?) ||
        (Setting.notified_events.include?('issue_priority_updated') && journal.new_value_for('priority_id').present?)
            Severity: Minor
            Found in lib/redmine_digest/digest.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method field_label has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def field_label
    return nil unless journal_detail
    case journal_detail.property
      when 'attr'
        field = journal_detail.prop_key.to_s.gsub(/_id$/, '')
            Severity: Minor
            Found in app/models/digest_event/base.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method cache_children has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def cache_children(projects)
      # first clear cache
      projects.each { |p| p.cached_children.clear }
      roots     = []
      ancestors = []
            Severity: Minor
            Found in lib/redmine_digest/patches/project_patch.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method set_default_values has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def set_default_values
    self.active           = true if active.nil?
    self.project_selector ||= MEMBER
    self.notify           ||= NOTIFY_AND_DIGEST
    self.recurrent        ||= WEEKLY
            Severity: Minor
            Found in app/models/digest_rule.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language