Showing 3 of 3 total issues
Method convert_blocks
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def convert_blocks(mapping)
user.pref.others[:my_page_layout].each do |zone, blocks|
blocks.map! do |block|
if block =~ OLD_BLOCK_RE
query_id = mapping[$1] && mapping[$1][:id]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method detect_new_text_block_from_params
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def detect_new_text_block_from_params(user = User.current)
block = params[:block].to_s.underscore
return nil unless block == MyPageQueries::TEXT_BLOCK
layout = user.pref[:my_page_layout] || {}
block_id = 1
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sort_link
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def sort_link(column, caption, default_order)
css, order = nil, default_order
if column.to_s == sort_criteria.first_key
if sort_criteria.first_asc?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"