Risoluto/Risoluto-Core

View on GitHub

Showing 66 of 128 total issues

Method play has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function play()
    {
        // セッションをスタート
        $sess = new \Risoluto\Session();
        $sess->start();
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/UserMng/ModComplete.php - About 1 hr to fix

Method test_getAttribute_ORACLE_NULLS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_ORACLE_NULLS()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_ALL has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_ALL()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_STATEMENT_CLASS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_STATEMENT_CLASS()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_CONNECTION_STATUS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_CONNECTION_STATUS()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_GenHour_NoArgs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_GenHour_NoArgs()
    {
        $want = [
            '00' => '00',
            '01' => '01',
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php - About 1 hr to fix

Method test_getAttribute_PREFETCH has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_PREFETCH()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_AUTOCOMMIT has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_AUTOCOMMIT()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_TIMEOUT has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_TIMEOUT()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_NoArgs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_NoArgs()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_SERVER_INFO has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_SERVER_INFO()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_DRIVER_NAME has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_DRIVER_NAME()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_DEFAULT_FETCH_MODE has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_DEFAULT_FETCH_MODE()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_CASE has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_CASE()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_ERRMODE has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_ERRMODE()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method test_getAttribute_PERSISTENT has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function test_getAttribute_PERSISTENT()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 1 hr to fix

Method play has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function play()
    {
        // セッションをスタート
        $sess = new \Risoluto\Session();
        $sess->start();
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/UserMng/AddComplete.php - About 1 hr to fix

Function checkEnteredSelfData has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function checkEnteredSelfData( $target, $csrf_token, $no )
    {
        // 戻り値を初期化
        $retval = [ ];
        $retval[ 'entered' ] = [ ];
Severity: Minor
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setUp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    protected function setUp()
    {
        // 拡張モジュールがロードされているかをチェック
        if (!extension_loaded( 'mysqli' )) {
            $this->markTestSkipped( 'Cannot use mysqli expansion module.' );
Severity: Minor
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function play has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function play()
    {
        // パラメタを取得し、空だった時はデフォルトの画面を取得する
        $params = $this->getParam();
        if (empty( $params ) or !preg_match( '/^[[:alnum:]_-].*$/', $params[ 0 ] )) {
Severity: Minor
Found in risoluto/apps/RisolutoApps/Pages/View.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language