Sign upLogin

Risoluto/Risoluto-Core

View on GitHub
Star

Showing 62 of 128 total issues

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    protected function setUp()
    {
        // 拡張モジュールがロードされているかをチェック
        if (!extension_loaded( 'mysqli' )) {
            $this->markTestSkipped( 'Cannot use mysqli expansion module.' );
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DoQuery.php and 5 other locations - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4Connect.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4ExecAndTransactions.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 41..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 140.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 6 locations. Consider refactoring.
Open

    protected function setUp()
    {
        // 拡張モジュールがロードされているかをチェック
        if (!extension_loaded( 'mysqli' )) {
            $this->markTestSkipped( 'Cannot use mysqli expansion module.' );
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4Connect.php and 5 other locations - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DoQuery.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4ExecAndTransactions.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4GetAttribute.php on lines 41..62
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 41..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 140.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '--' => '--',
            '00' => '00',
            '01' => '01',
            '02' => '02',
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php and 3 other locations - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 79..105
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 117..143
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 193..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '' => '',
            '00' => '00',
            '01' => '01',
            '02' => '02',
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php and 3 other locations - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 117..143
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 155..181
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 193..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '--' => '',
            '00' => '00',
            '01' => '01',
            '02' => '02',
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php and 3 other locations - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 79..105
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 155..181
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 193..219

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        $want = [
            '--' => '--',
            '00' => '午前00',
            '01' => '午前01',
            '02' => '午前02',
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php and 3 other locations - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 79..105
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 117..143
risoluto/lib/vendor_test/Risoluto/DateTest/DateTest4GenHour.php on lines 155..181

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 133.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (isset( $target[ 'username' ] ) and !empty( $target[ 'username' ] )) {
            // フォーマットチェック
            if (strlen( $target[ 'username' ] ) > 255) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_username';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 1 other location - About 2 hrs to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 279..291

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 129.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (isset( $target[ 'groupname' ] ) and !empty( $target[ 'groupname' ] )) {
            // フォーマットチェック
            if (strlen( $target[ 'groupname' ] ) > 255) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_groupname';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 1 other location - About 2 hrs to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 147..159

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 129.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * ValidateTest4IsEmailAddr
 *
 * Validate4IsEmailAddr用テストケース
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/ValidateTest/ValidateTest4IsEmailAddr.php and 1 other location - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/ValidateTest/ValidateTest4IsLeapYear.php on lines 1..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * ValidateTest4IsLeapYear
 *
 * Validate::IsLeapYear用テストケース
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/ValidateTest/ValidateTest4IsLeapYear.php and 1 other location - About 2 hrs to fix
risoluto/lib/vendor_test/Risoluto/ValidateTest/ValidateTest4IsEmailAddr.php on lines 1..82

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 125.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function test_setAttribute_EmptyBoth()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php and 2 other locations - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 128..147
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 154..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function test_setAttribute_Empty1st()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php and 2 other locations - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 102..121
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 154..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function test_setAttribute_Empty2nd()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php and 2 other locations - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 102..121
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4SetAttribute.php on lines 128..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 119.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (isset( $target[ 'status' ] )) {
            // フォーマットチェック
            if (!preg_match( '/\d{1,}/', $target[ 'status' ] )) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_status';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 2 other locations - About 1 hr to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 181..193
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 295..307

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (isset( $target[ 'status' ] )) {
            // フォーマットチェック
            if (!preg_match( '/\d{1,}/', $target[ 'status' ] )) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_status';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 2 other locations - About 1 hr to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 181..193
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 197..209

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (isset( $target[ 'groupno' ] )) {
            // フォーマットチェック
            if (!preg_match( '/\d{1,}/', $target[ 'groupno' ] )) {
                // フォーマットにそぐわない場合はエラーにする
                $retval[ 'error' ][ 'msg' ][ ] = 'invalid_groupno';
Severity: Major
Found in risoluto/apps/RisolutoApps/Admin/AdminCommon.php and 2 other locations - About 1 hr to fix
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 197..209
risoluto/apps/RisolutoApps/Admin/AdminCommon.php on lines 295..307

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function delGroup()
    {
        // ユーザ登録に必要な情報を順番に取得していく
        do {
            $option[ 'groupid' ] = $this->readFromStdin( "Enter group id: " );
Severity: Major
Found in risoluto/cli/RisolutoCli/AuthManager.php and 1 other location - About 1 hr to fix
risoluto/cli/RisolutoCli/AuthManager.php on lines 299..317

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private function delUser()
    {
        // 削除に必要な情報を順番に取得していく
        do {
            $option[ 'userid' ] = $this->readFromStdin( "Enter user id: " );
Severity: Major
Found in risoluto/cli/RisolutoCli/AuthManager.php and 1 other location - About 1 hr to fix
risoluto/cli/RisolutoCli/AuthManager.php on lines 330..348

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 111.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function test_DisConnect_with_force()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php and 1 other location - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php on lines 146..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function test_DisConnect_without_force()
    {
        $params = [
            "driver" => $GLOBALS[ 'DB_DRIVER' ],
            "user" => $GLOBALS[ 'DB_USER' ],
Severity: Major
Found in risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php and 1 other location - About 1 hr to fix
risoluto/lib/vendor_test/Risoluto/DbTest/DbTest4DisConnect.php on lines 124..139

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language