RocketChat/Rocket.Chat.Ops

View on GitHub
hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js

Summary

Maintainability
F
4 days
Test Coverage

Function all has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    Groups.prototype.all = function(params, fn) {
      var cb, data;
      if (params == null) {
        params = {};
      }
Severity: Minor
Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js - About 1 hr to fix

    Function addMember has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        Groups.prototype.addMember = function(groupId, userId, accessLevel, fn) {
          var checkAccessLevel, params;
          if (fn == null) {
            fn = null;
          }
    Severity: Minor
    Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          Groups.prototype.all = function(params, fn) {
            var cb, data;
            if (params == null) {
              params = {};
            }
      Severity: Major
      Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js and 2 other locations - About 1 day to fix
      hubots/hubot-gitsy/src/gitlab/lib/Models/Projects.js on lines 42..82
      hubots/hubot-gitsy/src/gitlab/lib/Models/Users.js on lines 27..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 332.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        var BaseModel, Groups,
          bind = function(fn, me){ return function(){ return fn.apply(me, arguments); }; },
          extend = function(child, parent) { for (var key in parent) { if (hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; },
          hasProp = {}.hasOwnProperty;
      Severity: Major
      Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js and 4 other locations - About 6 hrs to fix
      hubots/hubot-gitsy/src/gitlab/lib/ApiV3.js on lines 2..5
      hubots/hubot-gitsy/src/gitlab/lib/Models/Issues.js on lines 2..5
      hubots/hubot-gitsy/src/gitlab/lib/Models/UserKeys.js on lines 2..5
      hubots/hubot-gitsy/src/gitlab/lib/Models/Users.js on lines 2..5

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 169.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Groups.prototype.search = function(nameOrPath, fn) {
            var params;
            if (fn == null) {
              fn = null;
            }
      Severity: Major
      Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js and 1 other location - About 3 hrs to fix
      hubots/hubot-gitsy/src/gitlab/lib/Models/Users.js on lines 127..141

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 110.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Groups.prototype.show = function(groupId, fn) {
            if (fn == null) {
              fn = null;
            }
            this.debug("Groups::show()");
      Severity: Major
      Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js and 1 other location - About 3 hrs to fix
      hubots/hubot-gitsy/src/gitlab/lib/Models/Users.js on lines 81..93

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          Groups.prototype.create = function(params, fn) {
            if (params == null) {
              params = {};
            }
            if (fn == null) {
      Severity: Major
      Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js and 1 other location - About 3 hrs to fix
      hubots/hubot-gitsy/src/gitlab/lib/Models/Projects.js on lines 98..111

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            return this.get("groups/" + (parseInt(groupId)) + "/members", (function(_this) {
              return function(data) {
                if (fn) {
                  return fn(data);
                }
      Severity: Major
      Found in hubots/hubot-gitsy/src/gitlab/lib/Models/Groups.js and 1 other location - About 1 hr to fix
      hubots/hubot-gitsy/src/gitlab/lib/Models/UserKeys.js on lines 21..27

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status