Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/apps/server/converters/rooms.js

Summary

Maintainability
D
3 days
Test Coverage

Function convertRoom has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async convertRoom(room) {
        if (!room) {
            return undefined;
        }
Severity: Major
Found in apps/meteor/app/apps/server/converters/rooms.js - About 4 hrs to fix

    Function convertAppRoom has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async convertAppRoom(room) {
        if (!room) {
            return undefined;
        }
    Severity: Major
    Found in apps/meteor/app/apps/server/converters/rooms.js - About 3 hrs to fix

      Function convertRoom has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          async convertRoom(room) {
        if (!room) {
            return undefined;
        }
      Severity: Minor
      Found in apps/meteor/app/apps/server/converters/rooms.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convertAppRoom has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          async convertAppRoom(room) {
        if (!room) {
            return undefined;
        }
      Severity: Minor
      Found in apps/meteor/app/apps/server/converters/rooms.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  responseBy: async (room) => {
                const { responseBy } = room;

                if (!responseBy) {
                    return undefined;
      Severity: Major
      Found in apps/meteor/app/apps/server/converters/rooms.js and 2 other locations - About 2 hrs to fix
      apps/meteor/app/apps/server/converters/rooms.js on lines 162..172
      apps/meteor/app/apps/server/converters/rooms.js on lines 213..223

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  servedBy: async (room) => {
                const { servedBy } = room;

                if (!servedBy) {
                    return undefined;
      Severity: Major
      Found in apps/meteor/app/apps/server/converters/rooms.js and 2 other locations - About 2 hrs to fix
      apps/meteor/app/apps/server/converters/rooms.js on lines 162..172
      apps/meteor/app/apps/server/converters/rooms.js on lines 224..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                  creator: async (room) => {
                const { u } = room;

                if (!u) {
                    return undefined;
      Severity: Major
      Found in apps/meteor/app/apps/server/converters/rooms.js and 2 other locations - About 2 hrs to fix
      apps/meteor/app/apps/server/converters/rooms.js on lines 213..223
      apps/meteor/app/apps/server/converters/rooms.js on lines 224..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 79.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  department: async (room) => {
                const { departmentId } = room;

                if (!departmentId) {
                    return undefined;
      Severity: Major
      Found in apps/meteor/app/apps/server/converters/rooms.js and 1 other location - About 2 hrs to fix
      apps/meteor/app/apps/server/converters/rooms.js on lines 235..245

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  parentRoom: async (room) => {
                const { prid } = room;

                if (!prid) {
                    return undefined;
      Severity: Major
      Found in apps/meteor/app/apps/server/converters/rooms.js and 1 other location - About 2 hrs to fix
      apps/meteor/app/apps/server/converters/rooms.js on lines 202..212

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (room.servedBy) {
            const user = await Users.findOneById(room.servedBy.id);
            servedBy = {
                _id: user._id,
                username: user.username,
      Severity: Major
      Found in apps/meteor/app/apps/server/converters/rooms.js and 2 other locations - About 1 hr to fix
      apps/meteor/app/apps/server/converters/messages.js on lines 111..117
      apps/meteor/app/apps/server/converters/rooms.js on lines 70..76

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              if (room.closedBy) {
            const user = await Users.findOneById(room.closedBy.id);
            closedBy = {
                _id: user._id,
                username: user.username,
      Severity: Major
      Found in apps/meteor/app/apps/server/converters/rooms.js and 2 other locations - About 1 hr to fix
      apps/meteor/app/apps/server/converters/messages.js on lines 111..117
      apps/meteor/app/apps/server/converters/rooms.js on lines 61..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status