Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/authentication/server/startup/index.js

Summary

Maintainability
F
3 days
Test Coverage

File index.js has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Apps, AppEvents } from '@rocket.chat/apps';
import { User } from '@rocket.chat/core-services';
import { Roles, Settings, Users } from '@rocket.chat/models';
import { escapeRegExp, escapeHTML } from '@rocket.chat/string-helpers';
import { Accounts } from 'meteor/accounts-base';
Severity: Minor
Found in apps/meteor/app/authentication/server/startup/index.js - About 5 hrs to fix

    Function insertUserDocAsync has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    const insertUserDocAsync = async function (options, user) {
    const globalRoles = new Set();

    if (Match.test(options.globalRoles, [String]) && options.globalRoles.length > 0) {
        options.globalRoles.map((role) => globalRoles.add(role));
    Severity: Minor
    Found in apps/meteor/app/authentication/server/startup/index.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onCreateUserAsync has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

    const onCreateUserAsync = async function (options, user = {}) {
    if (!options.skipBeforeCreateUserCallback) {
        await beforeCreateUserCallback.run(options, user);
    }
    Severity: Minor
    Found in apps/meteor/app/authentication/server/startup/index.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function insertUserDocAsync has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const insertUserDocAsync = async function (options, user) {
    const globalRoles = new Set();

    if (Match.test(options.globalRoles, [String]) && options.globalRoles.length > 0) {
        options.globalRoles.map((role) => globalRoles.add(role));
    Severity: Major
    Found in apps/meteor/app/authentication/server/startup/index.js - About 2 hrs to fix

      Function onCreateUserAsync has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const onCreateUserAsync = async function (options, user = {}) {
    if (!options.skipBeforeCreateUserCallback) {
        await beforeCreateUserCallback.run(options, user);
    }
      Severity: Major
      Found in apps/meteor/app/authentication/server/startup/index.js - About 2 hrs to fix

        Function validateLoginAttemptAsync has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const validateLoginAttemptAsync = async function (login) {
    login = await callbacks.run('beforeValidateLogin', login);

    if (!(await isValidLoginAttemptByIp(getClientAddress(login.connection)))) {
        throw new Meteor.Error('error-login-blocked-for-ip', 'Login has been temporarily blocked For IP', {
        Severity: Minor
        Found in apps/meteor/app/authentication/server/startup/index.js - About 1 hr to fix

          Function validateLoginAttemptAsync has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          const validateLoginAttemptAsync = async function (login) {
    login = await callbacks.run('beforeValidateLogin', login);

    if (!(await isValidLoginAttemptByIp(getClientAddress(login.connection)))) {
        throw new Meteor.Error('error-login-blocked-for-ip', 'Login has been temporarily blocked For IP', {
          Severity: Minor
          Found in apps/meteor/app/authentication/server/startup/index.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getLinkedInName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          const getLinkedInName = ({ firstName, lastName }) => {
    const { preferredLocale, localized: firstNameLocalized } = firstName;
    const { localized: lastNameLocalized } = lastName;

    // LinkedIn new format
          Severity: Minor
          Found in apps/meteor/app/authentication/server/startup/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (Match.test(options.globalRoles, [String]) && options.globalRoles.length > 0) {
        options.globalRoles.map((role) => globalRoles.add(role));
    }
          Severity: Major
          Found in apps/meteor/app/authentication/server/startup/index.js and 1 other location - About 1 hr to fix
          apps/meteor/app/authentication/server/startup/index.js on lines 274..276

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (Match.test(user.globalRoles, [String]) && user.globalRoles.length > 0) {
        user.globalRoles.map((role) => globalRoles.add(role));
    }
          Severity: Major
          Found in apps/meteor/app/authentication/server/startup/index.js and 1 other location - About 1 hr to fix
          apps/meteor/app/authentication/server/startup/index.js on lines 270..272

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 65.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status