Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/integrations/server/api/api.js

Summary

Maintainability
F
3 days
Test Coverage

File api.js has 355 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Integrations, Users } from '@rocket.chat/models';
import { Random } from '@rocket.chat/random';
import _ from 'underscore';

import { API, APIClass, defaultRateLimiterOptions } from '../../../api/server';
Severity: Minor
Found in apps/meteor/app/integrations/server/api/api.js - About 4 hrs to fix

    Function executeIntegrationRest has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    async function executeIntegrationRest() {
    incomingLogger.info({ msg: 'Post integration:', integration: this.integration.name });
    incomingLogger.debug({ urlParams: this.urlParams, bodyParams: this.bodyParams });

    if (this.integration.enabled !== true) {
    Severity: Major
    Found in apps/meteor/app/integrations/server/api/api.js - About 3 hrs to fix

      Function executeIntegrationRest has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

      async function executeIntegrationRest() {
    incomingLogger.info({ msg: 'Post integration:', integration: this.integration.name });
    incomingLogger.debug({ urlParams: this.urlParams, bodyParams: this.bodyParams });

    if (this.integration.enabled !== true) {
      Severity: Minor
      Found in apps/meteor/app/integrations/server/api/api.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function user has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              async user() {
            const payloadKeys = Object.keys(this.bodyParams);
            const payloadIsWrapped = this.bodyParams && this.bodyParams.payload && payloadKeys.length === 1;
            if (payloadIsWrapped && this.request.headers['content-type'] === 'application/x-www-form-urlencoded') {
                try {
      Severity: Minor
      Found in apps/meteor/app/integrations/server/api/api.js - About 1 hr to fix

        Function integrationSampleRest has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function integrationSampleRest() {
    incomingLogger.info('Sample Integration');
    return {
        statusCode: 200,
        body: [
        Severity: Minor
        Found in apps/meteor/app/integrations/server/api/api.js - About 1 hr to fix

          Function createIntegration has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          async function createIntegration(options, user) {
    incomingLogger.info({ msg: 'Add integration', integration: options.name });
    incomingLogger.debug({ options });

    switch (options.event) {
          Severity: Minor
          Found in apps/meteor/app/integrations/server/api/api.js - About 1 hr to fix

            Function createIntegration has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

            async function createIntegration(options, user) {
    incomingLogger.info({ msg: 'Add integration', integration: options.name });
    incomingLogger.debug({ options });

    switch (options.event) {
            Severity: Minor
            Found in apps/meteor/app/integrations/server/api/api.js - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                    return API.v1.failure('overriding destination channel is disabled for this integration');
            Severity: Major
            Found in apps/meteor/app/integrations/server/api/api.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return API.v1.success(this.scriptResponse);
              Severity: Major
              Found in apps/meteor/app/integrations/server/api/api.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return API.v1.success();
                Severity: Major
                Found in apps/meteor/app/integrations/server/api/api.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return API.v1.failure('unknown-error');
                  Severity: Major
                  Found in apps/meteor/app/integrations/server/api/api.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return API.v1.failure(error || message);
                    Severity: Major
                    Found in apps/meteor/app/integrations/server/api/api.js - About 30 mins to fix

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                                  {
                token: Random.id(24),
                channel_id: Random.id(),
                channel_name: 'general',
                timestamp: new Date(),
                      Severity: Major
                      Found in apps/meteor/app/integrations/server/api/api.js and 2 other locations - About 1 hr to fix
                      apps/meteor/app/integrations/server/api/api.js on lines 206..215
                      apps/meteor/app/integrations/server/api/api.js on lines 216..225

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 67.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                                  {
                token: Random.id(24),
                channel_id: Random.id(),
                channel_name: 'general',
                timestamp: new Date(),
                      Severity: Major
                      Found in apps/meteor/app/integrations/server/api/api.js and 2 other locations - About 1 hr to fix
                      apps/meteor/app/integrations/server/api/api.js on lines 196..205
                      apps/meteor/app/integrations/server/api/api.js on lines 216..225

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 67.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                                  {
                token: Random.id(24),
                channel_id: Random.id(),
                channel_name: 'general',
                timestamp: new Date(),
                      Severity: Major
                      Found in apps/meteor/app/integrations/server/api/api.js and 2 other locations - About 1 hr to fix
                      apps/meteor/app/integrations/server/api/api.js on lines 196..205
                      apps/meteor/app/integrations/server/api/api.js on lines 206..215

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 67.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  return addOutgoingIntegration(user._id, {
                username: 'rocket.cat',
                urls: [options.target_url],
                name: options.name,
                channel: options.data.channel_name,
                      Severity: Major
                      Found in apps/meteor/app/integrations/server/api/api.js and 1 other location - About 1 hr to fix
                      apps/meteor/app/integrations/server/api/api.js on lines 44..50

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 64.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                                  return addOutgoingIntegration(user._id, {
                username: 'rocket.cat',
                urls: [options.target_url],
                name: options.name,
                channel: options.data.username,
                      Severity: Major
                      Found in apps/meteor/app/integrations/server/api/api.js and 1 other location - About 1 hr to fix
                      apps/meteor/app/integrations/server/api/api.js on lines 33..39

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 64.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status