Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/app/lib/server/functions/notifications/email.js

Summary

Maintainability
C
1 day
Test Coverage

Function getEmailContent has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

export async function getEmailContent({ message, user, room }) {
    const lng = (user && user.language) || settings.get('Language') || 'en';

    const roomName = escapeHTML(`#${await roomCoordinator.getRoomName(room.t, room)}`);
    const userName = escapeHTML(settings.get('UI_Use_Real_Name') ? message.u.name || message.u.username : message.u.username);
Severity: Minor
Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function shouldNotifyEmail has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export function shouldNotifyEmail({
    disableAllMessageNotifications,
    statusConnection,
    emailNotifications,
    isHighlighted,
Severity: Minor
Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getEmailData has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export async function getEmailData({ message, receiver, sender, subscription, room, emailAddress, hasMentionToUser }) {
    const username = settings.get('UI_Use_Real_Name') ? message.u.name || message.u.username : message.u.username;
    let subjectKey = 'Offline_Mention_All_Email';

    if (!roomCoordinator.getRoomDirectives(room.t).isGroupChat(room)) {
Severity: Minor
Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return `${header}:<br/><br/>${content}`;
Severity: Major
Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return false;
    Severity: Major
    Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return header;
      Severity: Major
      Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return `${fileHeader}:<br/><br/>${content}`;
        Severity: Major
        Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return header;
          Severity: Major
          Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return (
        (roomType === 'd' ||
            isHighlighted ||
            emailNotifications === 'all' ||
            hasMentionToUser ||
            Severity: Major
            Found in apps/meteor/app/lib/server/functions/notifications/email.js - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  const header = i18n.t(!roomDirectives.isGroupChat(room) ? 'User_sent_a_message_to_you' : 'User_sent_a_message_on_channel', {
        username: userName,
        channel: roomName,
        lng,
    });
              Severity: Minor
              Found in apps/meteor/app/lib/server/functions/notifications/email.js and 1 other location - About 40 mins to fix
              apps/meteor/app/lib/server/functions/notifications/email.js on lines 60..64

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      const fileHeader = i18n.t(!roomDirectives.isGroupChat(room) ? 'User_uploaded_a_file_to_you' : 'User_uploaded_a_file_on_channel', {
            username: userName,
            channel: roomName,
            lng,
        });
              Severity: Minor
              Found in apps/meteor/app/lib/server/functions/notifications/email.js and 1 other location - About 40 mins to fix
              apps/meteor/app/lib/server/functions/notifications/email.js on lines 32..36

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              export function shouldNotifyEmail({
    disableAllMessageNotifications,
    statusConnection,
    emailNotifications,
    isHighlighted,
              Severity: Minor
              Found in apps/meteor/app/lib/server/functions/notifications/email.js and 1 other location - About 40 mins to fix
              packages/livechat/src/components/Messages/Message/index.js on lines 33..57

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status