RocketChat/Rocket.Chat

View on GitHub
apps/meteor/app/slackbridge/server/SlackAPI.js

Summary

Maintainability
F
5 days
Test Coverage

Consider simplifying this complex logical expression.
Open

            if (response && response && request.status === 200 && request.ok && Array.isArray(response.members)) {
                members = members.concat(response.members);
                const hasMoreItems = response.response_metadata && response.response_metadata.next_cursor;
                if (hasMoreItems) {
                    currentCursor = response.response_metadata.next_cursor;
Severity: Major
Found in apps/meteor/app/slackbridge/server/SlackAPI.js - About 40 mins to fix

    Function getMembers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        async getMembers(channelId) {
            const { num_members } = this.getRoomInfo(channelId);
            const MAX_MEMBERS_PER_CALL = 100;
            let members = [];
            let currentCursor = '';
    Severity: Minor
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getChannels has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        async getChannels(cursor = null) {
            let channels = [];
            const request = await fetch('https://slack.com/api/conversations.list', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
    Severity: Minor
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async getChannels(cursor = null) {
            let channels = [];
            const request = await fetch('https://slack.com/api/conversations.list', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 1 other location - About 1 day to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 34..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 238.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async getGroups(cursor = null) {
            let groups = [];
            const request = await fetch('https://slack.com/api/conversations.list', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 1 other location - About 1 day to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 8..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 238.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async getPins(channelId) {
            const request = await fetch('https://slack.com/api/pins.list', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
                },
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 1 other location - About 3 hrs to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 187..198

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        async getUser(userId) {
            const request = await fetch('https://slack.com/api/users.info', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
                },
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 1 other location - About 3 hrs to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 174..185

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        async updateMessage(data) {
            const request = await fetch('https://slack.com/api/chat.update', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
                },
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 3 other locations - About 3 hrs to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 104..114
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 116..126
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 128..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        async removeReaction(data) {
            const request = await fetch('https://slack.com/api/reactions.remove', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
                },
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 3 other locations - About 3 hrs to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 104..114
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 128..138
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 151..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        async removeMessage(data) {
            const request = await fetch('https://slack.com/api/chat.delete', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
                },
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 3 other locations - About 3 hrs to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 104..114
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 116..126
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 151..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        async react(data) {
            const request = await fetch('https://slack.com/api/reactions.add', {
                headers: {
                    Authorization: `Bearer ${this.token}`,
                },
    Severity: Major
    Found in apps/meteor/app/slackbridge/server/SlackAPI.js and 3 other locations - About 3 hrs to fix
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 116..126
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 128..138
    apps/meteor/app/slackbridge/server/SlackAPI.js on lines 151..161

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status