Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/packages/autoupdate/autoupdate_client.js

Summary

Maintainability
D
2 days
Test Coverage

Function _retrySubscription has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

Autoupdate._retrySubscription = () => {
    Meteor.subscribe('meteor_autoupdate_clientVersions', {
        onError(error) {
            Meteor._debug('autoupdate subscription failed', error);
            failures++;
Severity: Minor
Found in apps/meteor/packages/autoupdate/autoupdate_client.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _retrySubscription has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Autoupdate._retrySubscription = () => {
    Meteor.subscribe('meteor_autoupdate_clientVersions', {
        onError(error) {
            Meteor._debug('autoupdate subscription failed', error);
            failures++;
Severity: Major
Found in apps/meteor/packages/autoupdate/autoupdate_client.js - About 3 hrs to fix

    Function onReady has 82 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            onReady() {
            // Call checkNewVersionDocument with a slight delay, so that the
            // const handle declaration is guaranteed to be initialized, even if
            // the added or changed callbacks are called synchronously.
            const resolved = Promise.resolve();
    Severity: Major
    Found in apps/meteor/packages/autoupdate/autoupdate_client.js - About 3 hrs to fix

      Function checkNewVersionDocument has 74 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                  function checkNewVersionDocument(doc) {
                if (doc._id !== clientArch) {
                    return;
                }
      Severity: Major
      Found in apps/meteor/packages/autoupdate/autoupdate_client.js - About 2 hrs to fix

        There are no issues that match your filters.

        Category
        Status