Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/packages/meteor-cookies/cookies.js

Summary

Maintainability
F
3 days
Test Coverage

File cookies.js has 382 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Meteor } from 'meteor/meteor';

let fetch;
let WebApp;
Severity: Minor
Found in apps/meteor/packages/meteor-cookies/cookies.js - About 5 hrs to fix

    Function serialize has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

    const serialize = (key, val, opt = {}) => {
    let name;

    if (!fieldContentRegExp.test(key)) {
        name = escape(key);
    Severity: Minor
    Found in apps/meteor/packages/meteor-cookies/cookies.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function serialize has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const serialize = (key, val, opt = {}) => {
    let name;

    if (!fieldContentRegExp.test(key)) {
        name = escape(key);
    Severity: Major
    Found in apps/meteor/packages/meteor-cookies/cookies.js - About 2 hrs to fix

      Function constructor has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor(opts = {}) {
        opts.TTL = helpers.isNumber(opts.TTL) ? opts.TTL : false;
        opts.runOnServer = opts.runOnServer !== false ? true : false;
        opts.allowQueryStringCookies = opts.allowQueryStringCookies !== true ? false : true;
      Severity: Major
      Found in apps/meteor/packages/meteor-cookies/cookies.js - About 2 hrs to fix

        Function constructor has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            constructor(opts = {}) {
        opts.TTL = helpers.isNumber(opts.TTL) ? opts.TTL : false;
        opts.runOnServer = opts.runOnServer !== false ? true : false;
        opts.allowQueryStringCookies = opts.allowQueryStringCookies !== true ? false : true;
        Severity: Minor
        Found in apps/meteor/packages/meteor-cookies/cookies.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function send has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            send(cb = NoOp) {
        if (Meteor.isServer) {
            cb(new Meteor.Error(400, "Can't run `.send()` on server, it's Client only method!"));
        }
        Severity: Minor
        Found in apps/meteor/packages/meteor-cookies/cookies.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function send has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            send(cb = NoOp) {
        if (Meteor.isServer) {
            cb(new Meteor.Error(400, "Can't run `.send()` on server, it's Client only method!"));
        }
        Severity: Minor
        Found in apps/meteor/packages/meteor-cookies/cookies.js - About 1 hr to fix

          Function deserialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          const deserialize = (string) => {
    if (typeof string !== 'string') {
        return string;
    }
          Severity: Minor
          Found in apps/meteor/packages/meteor-cookies/cookies.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                                  if (urlRE.test(req._parsedUrl.path)) {
                            const matchedCordovaOrigin =
                                !!req.headers.origin && this.allowedCordovaOrigins && this.allowedCordovaOrigins.test(req.headers.origin);
                            const matchedOrigin = matchedCordovaOrigin || (!!req.headers.origin && this.originRE.test(req.headers.origin));
          Severity: Major
          Found in apps/meteor/packages/meteor-cookies/cookies.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                        if (matchedCordovaOrigin && opts.allowQueryStringCookies && req.query.___cookies___) {
                                cookiesObject = parse(decodeURIComponent(req.query.___cookies___));
                            } else if (req.headers.cookie) {
                                cookiesObject = parse(req.headers.cookie);
                            }
            Severity: Major
            Found in apps/meteor/packages/meteor-cookies/cookies.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if (cookiesKeys.length) {
                                for (let i = 0; i < cookiesKeys.length; i++) {
                                    const { cookieString } = serialize(cookiesKeys[i], cookiesObject[cookiesKeys[i]]);
                                    if (!cookiesArray.includes(cookieString)) {
                                        cookiesArray.push(cookieString);
              Severity: Major
              Found in apps/meteor/packages/meteor-cookies/cookies.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if (matchedOrigin) {
                                res.setHeader('Access-Control-Allow-Credentials', 'true');
                                res.setHeader('Access-Control-Allow-Origin', req.headers.origin);
                            }
                Severity: Major
                Found in apps/meteor/packages/meteor-cookies/cookies.js - About 45 mins to fix

                  Function remove has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      remove(key, path = '/', domain = '') {
        if (key && this.cookies.hasOwnProperty(key)) {
            const { cookieString } = serialize(key, '', {
                domain,
                path,
                  Severity: Minor
                  Found in apps/meteor/packages/meteor-cookies/cookies.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function set has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      set(key, value, opts = {}) {
        if (key && !helpers.isUndefined(value)) {
            if (helpers.isNumber(this.TTL) && opts.expires === undefined) {
                opts.expires = new Date(+new Date() + this.TTL);
            }
                  Severity: Minor
                  Found in apps/meteor/packages/meteor-cookies/cookies.js - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this function.
                  Open

                              return string;
                  Severity: Major
                  Found in apps/meteor/packages/meteor-cookies/cookies.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                        return string;
                    Severity: Major
                    Found in apps/meteor/packages/meteor-cookies/cookies.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return JSON.parse(string);
                      Severity: Major
                      Found in apps/meteor/packages/meteor-cookies/cookies.js - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if (opt.path && typeof opt.path === 'string') {
        if (!fieldContentRegExp.test(opt.path)) {
            throw new Meteor.Error(404, 'option path is invalid');
        }
        pairs.push(`Path=${opt.path}`);
                        Severity: Major
                        Found in apps/meteor/packages/meteor-cookies/cookies.js and 1 other location - About 1 hr to fix
                        apps/meteor/packages/meteor-cookies/cookies.js on lines 204..209

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 61.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            if (opt.domain && typeof opt.domain === 'string') {
        if (!fieldContentRegExp.test(opt.domain)) {
            throw new Meteor.Error(404, 'option domain is invalid');
        }
        pairs.push(`Domain=${opt.domain}`);
                        Severity: Major
                        Found in apps/meteor/packages/meteor-cookies/cookies.js and 1 other location - About 1 hr to fix
                        apps/meteor/packages/meteor-cookies/cookies.js on lines 211..218

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 61.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        const rootUrl = Meteor.isServer
    ? process.env.ROOT_URL
    : window.__meteor_runtime_config__.ROOT_URL || window.__meteor_runtime_config__.meteorEnv.ROOT_URL || false;
                        Severity: Minor
                        Found in apps/meteor/packages/meteor-cookies/cookies.js and 1 other location - About 55 mins to fix
                        apps/meteor/packages/meteor-cookies/cookies.js on lines 17..19

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 53.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        const mobileRootUrl = Meteor.isServer
    ? process.env.MOBILE_ROOT_URL
    : window.__meteor_runtime_config__.MOBILE_ROOT_URL || window.__meteor_runtime_config__.meteorEnv.MOBILE_ROOT_URL || false;
                        Severity: Minor
                        Found in apps/meteor/packages/meteor-cookies/cookies.js and 1 other location - About 55 mins to fix
                        apps/meteor/packages/meteor-cookies/cookies.js on lines 14..16

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 53.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status