Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/packages/meteor-restivus/lib/restivus.js

Summary

Maintainability
D
1 day
Test Coverage

Function _initAuth has 101 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    _initAuth() {
        const self = this;

        /*
            Add a login endpoint to the API
Severity: Major
Found in apps/meteor/packages/meteor-restivus/lib/restivus.js - About 4 hrs to fix

    Function _initAuth has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        _initAuth() {
        const self = this;

        /*
            Add a login endpoint to the API
    Severity: Minor
    Found in apps/meteor/packages/meteor-restivus/lib/restivus.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function constructor has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        constructor(options) {
        this._routes = [];
        this._config = {
            paths: [],
            useDefaultAuth: false,
    Severity: Major
    Found in apps/meteor/packages/meteor-restivus/lib/restivus.js - About 2 hrs to fix

      Function post has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      async post() {
                    const user = {};
                    if (this.bodyParams.user) {
                        if (this.bodyParams.user.indexOf('@') === -1) {
                            user.username = this.bodyParams.user;
      Severity: Minor
      Found in apps/meteor/packages/meteor-restivus/lib/restivus.js - About 1 hr to fix

        Function constructor has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            constructor(options) {
        this._routes = [];
        this._config = {
            paths: [],
            useDefaultAuth: false,
        Severity: Minor
        Found in apps/meteor/packages/meteor-restivus/lib/restivus.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function logout has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                const logout = async function () {
            const authToken = this.request.headers['x-auth-token'];
            const hashedToken = Accounts._hashLoginToken(authToken);
            const tokenLocation = self._config.auth.token;
            const index = tokenLocation.lastIndexOf('.');
        Severity: Minor
        Found in apps/meteor/packages/meteor-restivus/lib/restivus.js - About 1 hr to fix

          There are no issues that match your filters.

          Category
          Status