Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star
apps/meteor/server/configuration/accounts_meld.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function configureAccounts has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

export async function configureAccounts() {
    const orig_updateOrCreateUserFromExternalService = Accounts.updateOrCreateUserFromExternalService;

    const updateOrCreateUserFromExternalServiceAsync = async function (serviceName, serviceData = {}, ...args /* , options*/) {
        const services = ['facebook', 'github', 'gitlab', 'google', 'meteor-developer', 'linkedin', 'twitter', 'apple'];
Severity: Minor
Found in apps/meteor/server/configuration/accounts_meld.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function configureAccounts has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function configureAccounts() {
    const orig_updateOrCreateUserFromExternalService = Accounts.updateOrCreateUserFromExternalService;

    const updateOrCreateUserFromExternalServiceAsync = async function (serviceName, serviceData = {}, ...args /* , options*/) {
        const services = ['facebook', 'github', 'gitlab', 'google', 'meteor-developer', 'linkedin', 'twitter', 'apple'];
Severity: Minor
Found in apps/meteor/server/configuration/accounts_meld.js - About 1 hr to fix

    Function updateOrCreateUserFromExternalServiceAsync has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const updateOrCreateUserFromExternalServiceAsync = async function (serviceName, serviceData = {}, ...args /* , options*/) {
        const services = ['facebook', 'github', 'gitlab', 'google', 'meteor-developer', 'linkedin', 'twitter', 'apple'];

        if (services.includes(serviceName) === false && serviceData._OAuthCustom !== true) {
            return orig_updateOrCreateUserFromExternalService.apply(this, [serviceName, serviceData, ...args]);
    Severity: Minor
    Found in apps/meteor/server/configuration/accounts_meld.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status