Sign upLogin

RocketChat/Rocket.Chat

View on GitHub
Star

Showing 3,299 of 8,337 total issues

Function getMembers has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async getMembers(channelId) {
        const { num_members } = this.getRoomInfo(channelId);
        const MAX_MEMBERS_PER_CALL = 100;
        let members = [];
        let currentCursor = '';
Severity: Minor
Found in apps/meteor/app/slackbridge/server/SlackAPI.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getChannels has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async getChannels(cursor = null) {
        let channels = [];
        const request = await fetch('https://slack.com/api/conversations.list', {
            headers: {
                Authorization: `Bearer ${this.token}`,
Severity: Minor
Found in apps/meteor/app/slackbridge/server/SlackAPI.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAppsStatistics has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function getAppsStatistics() {
    return {
        engineVersion: Info.marketplaceApiVersion,
        totalInstalled: (Apps.self?.isInitialized() && Apps.getManager().get().length) ?? 0,
        totalActive: (Apps.self?.isInitialized() && Apps.getManager().get({ enabled: true }).length) ?? 0,
Severity: Minor
Found in apps/meteor/app/statistics/server/lib/getAppsStatistics.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function componentDidUpdate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async componentDidUpdate(prevProps) {
        const { messages, dispatch, user } = this.props;
        const { messages: prevMessages, alerts: prevAlerts } = prevProps;

        const renderedMessages = messages.filter((message) => canRenderMessage(message));
Severity: Minor
Found in packages/livechat/src/routes/Chat/container.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processGroupJoinMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async processGroupJoinMessage(rocketChannel, rocketUser, slackMessage, isImporting) {
        if (slackMessage.inviter) {
            const inviter = slackMessage.inviter
                ? (await this.rocket.findUser(slackMessage.inviter)) || (await this.rocket.addUser(slackMessage.inviter))
                : null;
Severity: Minor
Found in apps/meteor/app/slackbridge/server/SlackAdapter.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleNickname has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

const handleNickname = (updateUser, nickname) => {
    if (nickname && nickname.trim()) {
        if (nickname.length > MAX_NICKNAME_LENGTH) {
            throw new Meteor.Error('error-nickname-size-exceeded', `Nickname size exceeds ${MAX_NICKNAME_LENGTH} characters`, {
                method: 'saveUserProfile',
Severity: Minor
Found in apps/meteor/app/lib/server/functions/saveUser.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function populateMembershipChannelMapByChannels has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async populateMembershipChannelMapByChannels() {
        const channels = await this.slackAPI.getChannels();
        if (!channels || channels.length <= 0) {
            return;
        }
Severity: Minor
Found in apps/meteor/app/slackbridge/server/SlackAdapter.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function postDeleteMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async postDeleteMessage(rocketMessage) {
        if (rocketMessage) {
            const slackChannel = this.getSlackChannel(rocketMessage.rid);

            if (slackChannel != null) {
Severity: Minor
Found in apps/meteor/app/slackbridge/server/SlackAdapter.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getLinkedInName has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

const getLinkedInName = ({ firstName, lastName }) => {
    const { preferredLocale, localized: firstNameLocalized } = firstName;
    const { localized: lastNameLocalized } = lastName;

    // LinkedIn new format
Severity: Minor
Found in apps/meteor/app/authentication/server/startup/index.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function processPinnedItemMessage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async processPinnedItemMessage(rocketChannel, rocketUser, slackMessage, isImporting) {
        if (slackMessage.attachments && slackMessage.attachments[0] && slackMessage.attachments[0].text) {
            // TODO: refactor this logic to use the service to send this system message instead of using sendMessage
            const rocketMsgObj = {
                rid: rocketChannel._id,
Severity: Minor
Found in apps/meteor/app/slackbridge/server/SlackAdapter.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    constructor(selfId, room, autoAccept = false) {
        this.config = {
            iceServers: [],
        };
        this.debug = false;
Severity: Minor
Found in apps/meteor/app/webrtc/client/WebRTCClass.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleBio has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

const handleBio = (updateUser, bio) => {
    if (bio && bio.trim()) {
        if (bio.length > MAX_BIO_LENGTH) {
            throw new Meteor.Error('error-bio-size-exceeded', `Bio size exceeds ${MAX_BIO_LENGTH} characters`, {
                method: 'saveUserProfile',
Severity: Minor
Found in apps/meteor/app/lib/server/functions/saveUser.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function populateMembershipChannelMapByGroups has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async populateMembershipChannelMapByGroups() {
        const groups = await this.slackAPI.getGroups();
        if (!groups || groups.length <= 0) {
            return;
        }
Severity: Minor
Found in apps/meteor/app/slackbridge/server/SlackAdapter.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onRemoteJoin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    onRemoteJoin(data, ...args) {
        if (this.active !== true) {
            return;
        }
        this.log('onRemoteJoin', [data, ...args]);
Severity: Minor
Found in apps/meteor/app/webrtc/client/WebRTCClass.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function storeReadReceipts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    async storeReadReceipts(messages, roomId, userId, extraData = {}) {
        if (settings.get('Message_Read_Receipt_Store_Users')) {
            const ts = new Date();
            const receipts = messages.map((message) => ({
                _id: Random.id(),
Severity: Minor
Found in apps/meteor/ee/server/lib/message-read-receipt/ReadReceipt.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function timeAgo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function timeAgo(dateParam: number, locale: string): string {
    const int = new Intl.RelativeTimeFormat(locale, { style: 'long' });

    const date = new Date(dateParam).getTime();
    const today = new Date().getTime();
Severity: Minor
Found in packages/gazzodown/src/elements/Timestamp/timeago.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function LinkSpan has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

const LinkSpan = ({ href, label }: LinkSpanProps): ReactElement => {
    const t = useTranslation();
    const children = useMemo(() => {
        const labelArray = Array.isArray(label) ? label : [label];
Severity: Minor
Found in packages/gazzodown/src/elements/LinkSpan.tsx - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function MockedServerContext has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export const MockedServerContext = ({
    handleRequest,
    handleMethod,
    children,
Severity: Minor
Found in packages/mock-providers/src/MockedServerContext.tsx - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ironRouterSendErrorToResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export function ironRouterSendErrorToResponse(err, req, res) {
    if (res.statusCode < 400) res.statusCode = 500;

    if (err.status) res.statusCode = err.status;
Severity: Minor
Found in apps/meteor/packages/meteor-restivus/lib/iron-router-error-to-response.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function makeFunction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export const makeFunction = <T extends BaseFunction>(fn: T): PatchedFunction<T> => {
    const patches = new Set<PatchData<T>>();

    patches.add({
        patchFunction: (_next, ...args) => fn(...args),
Severity: Minor
Found in packages/patch-injection/src/makeFunction.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language