Sign upLogin

RouteInjector/route-injector

View on GitHub
Star
lib/engine/routeinjector/newdenormalizer.js

Summary

Maintainability
F
4 days
Test Coverage

Function denormalize has 204 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports.denormalize = function (field, rkey, Model, isArray, fullPath) {
    var needsFromDBhook = true;
    var denormalizedFields = field.denormalize;
    log.debug("Adding denormalized params :\"" + denormalizedFields + "\" to field " + fullPath + " in model " + Model.modelName);
Severity: Major
Found in lib/engine/routeinjector/newdenormalizer.js - About 1 day to fix

    Function genDenorm has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

    function genDenorm(dest, src, denormalized, confRid, plain, doc, path) {
    if (src) {
        dest = {};
        var target;
        if (plain == true) {
    Severity: Minor
    Found in lib/engine/routeinjector/newdenormalizer.js - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function denormalize has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports.denormalize = function (field, rkey, Model, isArray, fullPath) {
    var needsFromDBhook = true;
    var denormalizedFields = field.denormalize;
    log.debug("Adding denormalized params :\"" + denormalizedFields + "\" to field " + fullPath + " in model " + Model.modelName);
    Severity: Minor
    Found in lib/engine/routeinjector/newdenormalizer.js - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File newdenormalizer.js has 267 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var utils = require('./utils');
var Q = require('q');
var _ = require('lodash');
var injector = require('../../');
var async = require('async');
    Severity: Minor
    Found in lib/engine/routeinjector/newdenormalizer.js - About 2 hrs to fix

      Function toDB has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          Model.injector()._references.toDB = function (doc, cb) {
        var defer = Q.defer();
        var self = doc;
        var promises = [];
      Severity: Major
      Found in lib/engine/routeinjector/newdenormalizer.js - About 2 hrs to fix

        Function propagate has 58 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                RefModel.injector()._references.propagate = function (doc) {
            var models = Object.keys(RefModel.injector()._references.propagations);
            var promises = [];

            async.each(models, function (item, cb) {
        Severity: Major
        Found in lib/engine/routeinjector/newdenormalizer.js - About 2 hrs to fix

          Function fromDB has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  Model.injector()._references.fromDB = function (doc, cb) {
            var defer = Q.defer();
            var promises = [];
            var doc2 = doc.toObject();
          Severity: Major
          Found in lib/engine/routeinjector/newdenormalizer.js - About 2 hrs to fix

            Function genDenorm has 44 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function genDenorm(dest, src, denormalized, confRid, plain, doc, path) {
    if (src) {
        dest = {};
        var target;
        if (plain == true) {
            Severity: Minor
            Found in lib/engine/routeinjector/newdenormalizer.js - About 1 hr to fix

              Function genDenorm has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function genDenorm(dest, src, denormalized, confRid, plain, doc, path) {
              Severity: Major
              Found in lib/engine/routeinjector/newdenormalizer.js - About 50 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if (value !== undefined) {
                        _.set(target, f, value);
                    }
                Severity: Major
                Found in lib/engine/routeinjector/newdenormalizer.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                      if (value !== undefined) {
                        _.set(target, f.target, value);
                    }
                  Severity: Major
                  Found in lib/engine/routeinjector/newdenormalizer.js - About 45 mins to fix

                    Function denormalize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    module.exports.denormalize = function (field, rkey, Model, isArray, fullPath) {
                    Severity: Minor
                    Found in lib/engine/routeinjector/newdenormalizer.js - About 35 mins to fix

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                          if (promises.length > 0) {
                        utils.allSeries(promises).then(end, log.error.bind(log));
                    } else {
                        end();
                    }
                      Severity: Major
                      Found in lib/engine/routeinjector/newdenormalizer.js and 1 other location - About 1 hr to fix
                      lib/engine/routeinjector/newdenormalizer.js on lines 282..286

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 57.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                                          if (promises.length > 0) {
                        utils.allSeries(promises).then(end, log.error.bind(log));
                    } else {
                        end();
                    }
                      Severity: Major
                      Found in lib/engine/routeinjector/newdenormalizer.js and 1 other location - About 1 hr to fix
                      lib/engine/routeinjector/newdenormalizer.js on lines 223..227

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 57.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status