Sign upLogin

RubyLouvre/anu

View on GitHub
Star
packages/core/__tests__/ReactPureComponent-test.js

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    expect(() => ReactDOM.render(<Component />, container)).toWarnDev(
      'Warning: ' +
        'Component has a method called shouldComponentUpdate(). ' +
        'shouldComponentUpdate should not be used when extending React.PureComponent. ' +
        'Please extend React.Component if shouldComponentUpdate is used.',
Severity: Major
Found in packages/core/__tests__/ReactPureComponent-test.js and 6 other locations - About 30 mins to fix
packages/core/__tests__/ReactElement-test.js on lines 78..83
packages/core/__tests__/ReactElement-test.js on lines 112..117
packages/core/__tests__/ReactPureComponent-test.js on lines 103..108
packages/render/dom/__tests__/ReactComponent-test.js on lines 587..592
packages/render/dom/__tests__/ReactComponent-test.js on lines 602..607
packages/render/dom/__tests__/ReactMount-test.js on lines 186..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

    expect(() => ReactDOM.render(<PureComponent />, container)).toWarnDev(
      'Warning: ' +
        'PureComponent has a method called shouldComponentUpdate(). ' +
        'shouldComponentUpdate should not be used when extending React.PureComponent. ' +
        'Please extend React.Component if shouldComponentUpdate is used.',
Severity: Major
Found in packages/core/__tests__/ReactPureComponent-test.js and 6 other locations - About 30 mins to fix
packages/core/__tests__/ReactElement-test.js on lines 78..83
packages/core/__tests__/ReactElement-test.js on lines 112..117
packages/core/__tests__/ReactPureComponent-test.js on lines 69..74
packages/render/dom/__tests__/ReactComponent-test.js on lines 587..592
packages/render/dom/__tests__/ReactComponent-test.js on lines 602..607
packages/render/dom/__tests__/ReactMount-test.js on lines 186..191

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status