RubyLouvre/anu

View on GitHub
packages/render/dom/__tests__/ReactDOMTextarea-test.js

Summary

Maintainability
D
2 days
Test Coverage

File ReactDOMTextarea-test.js has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open


const emptyFunction = function(){}

describe('ReactDOMTextarea', () => {
  let React;
Severity: Minor
Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should allow setting `value` to `false`', () => {
        const container = document.createElement('div');
        let stub = <textarea value="giraffe" onChange={emptyFunction} />;
        const node = renderTextarea(stub, container);
    
    
    Severity: Major
    Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js and 1 other location - About 5 hrs to fix
    packages/render/dom/__tests__/ReactDOMTextarea-test.js on lines 134..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should allow setting `value` to `true`', () => {
        const container = document.createElement('div');
        let stub = <textarea value="giraffe" onChange={emptyFunction} />;
        const node = renderTextarea(stub, container);
    
    
    Severity: Major
    Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js and 1 other location - About 5 hrs to fix
    packages/render/dom/__tests__/ReactDOMTextarea-test.js on lines 148..160

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 139.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(() =>
          ReactTestUtils.renderIntoDocument(
            <textarea value="foo" defaultValue="bar" readOnly={true} />,
          ),
        ).toWarnDev(
    Severity: Major
    Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js and 1 other location - About 1 hr to fix
    packages/render/dom/__tests__/ReactDOMInput-test.js on lines 889..899

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should display `defaultValue` of number 0', () => {
        const stub = <textarea defaultValue={0} />;
        const node = renderTextarea(stub);
    
        expect(node.value).toBe('0');
    Severity: Major
    Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js and 1 other location - About 1 hr to fix
    packages/render/dom/__tests__/ReactDOMTextarea-test.js on lines 89..94

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      it('should display `value` of number 0', () => {
        const stub = <textarea value={0} />;
        const node = renderTextarea(stub);
    
        expect(node.value).toBe('0');
    Severity: Major
    Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js and 1 other location - About 1 hr to fix
    packages/render/dom/__tests__/ReactDOMTextarea-test.js on lines 47..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

        Object.defineProperty(node, 'value', {
          get: function() {
            return nodeValue;
          },
          set: nodeValueSetter.mockImplementation(function(newValue) {
    Severity: Major
    Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js and 3 other locations - About 55 mins to fix
    packages/render/dom/__tests__/ReactDOMInput-test.js on lines 534..541
    packages/render/dom/__tests__/ReactDOMInput-test.js on lines 557..564
    packages/render/dom/__tests__/ReactDOMInput-test.js on lines 577..584

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        expect(() =>
          ReactTestUtils.renderIntoDocument(<textarea value={null} />),
        ).toWarnDev(
          '`value` prop on `textarea` should not be null. ' +
            'Consider using an empty string to clear the component or `undefined` ' +
    Severity: Minor
    Found in packages/render/dom/__tests__/ReactDOMTextarea-test.js and 1 other location - About 35 mins to fix
    packages/core/__tests__/ReactJSXElementValidator-test.js on lines 233..239

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status