Sign upLogin

RubyLouvre/anu

View on GitHub
Star
packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js

Summary

Maintainability
D
1 day
Test Coverage

File renderSubtreeIntoContainer-test.js has 259 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const React = require('react');
const PropTypes = require('prop-types');
const ReactDOM = require('react-dom');
Severity: Minor
Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js - About 2 hrs to fix

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

        class Component extends React.Component {
      static contextTypes = {
        foo: PropTypes.string.isRequired,
        getFoo: PropTypes.func.isRequired,
      };
    Severity: Major
    Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js and 3 other locations - About 3 hrs to fix
    packages/render/dom/__tests__/ReactDOMFiber-test.js on lines 744..753
    packages/render/dom/__tests__/ReactDOMFiber-test.js on lines 788..797
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 96..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

        class Component extends React.Component {
      static contextTypes = {
        foo: PropTypes.string.isRequired,
        getFoo: PropTypes.func.isRequired,
      };
    Severity: Major
    Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js and 3 other locations - About 3 hrs to fix
    packages/render/dom/__tests__/ReactDOMFiber-test.js on lines 744..753
    packages/render/dom/__tests__/ReactDOMFiber-test.js on lines 788..797
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 148..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 95.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        class Child extends React.Component {
      static contextTypes = {
        value: PropTypes.string.isRequired,
      };
      render() {
    Severity: Major
    Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js and 4 other locations - About 1 hr to fix
    packages/render/dom/__tests__/ReactDOMFiber-test.js on lines 710..718
    packages/render/dom/__tests__/ReactStatelessComponent-test.js on lines 54..62
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 14..22
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 279..286

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        class Child extends React.Component {
      static contextTypes = {
        value: PropTypes.string.isRequired,
      };
      render() {
    Severity: Major
    Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js and 4 other locations - About 1 hr to fix
    packages/render/dom/__tests__/ReactDOMFiber-test.js on lines 710..718
    packages/render/dom/__tests__/ReactStatelessComponent-test.js on lines 54..62
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 14..22
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 236..243

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        class Component extends React.Component {
      static contextTypes = {
        foo: PropTypes.string.isRequired,
      };
    Severity: Major
    Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js and 4 other locations - About 1 hr to fix
    packages/render/dom/__tests__/ReactDOMFiber-test.js on lines 710..718
    packages/render/dom/__tests__/ReactStatelessComponent-test.js on lines 54..62
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 236..243
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 279..286

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        class Middle extends React.Component {
      render() {
        return null;
      }
      componentDidMount() {
    Severity: Minor
    Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js and 1 other location - About 35 mins to fix
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 270..277

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        class Middle extends React.Component {
      render() {
        return null;
      }
      componentDidMount() {
    Severity: Minor
    Found in packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js and 1 other location - About 35 mins to fix
    packages/render/dom/__tests__/renderSubtreeIntoContainer-test.js on lines 227..234

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status