RubyLouvre/avalon

View on GitHub
src/directives/visible.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function update has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
Open

    update: function (vdom, show) {     
        var dom = vdom.dom
        if (dom && dom.nodeType === 1) {
            var display = dom.style.display
            var value
Severity: Minor
Found in src/directives/visible.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    update: function (vdom, show) {     
        var dom = vdom.dom
        if (dom && dom.nodeType === 1) {
            var display = dom.style.display
            var value
Severity: Minor
Found in src/directives/visible.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            if (dom.style.cssText === '') {
                                dom.removeAttribute('style')
                            }
    Severity: Major
    Found in src/directives/visible.js - About 45 mins to fix

      BUG found
      Open

                          // fix firefox BUG,必须挂到页面上
      Severity: Minor
      Found in src/directives/visible.js by fixme

      Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
      Open

      import { avalon } from '../seed/core'
      Severity: Minor
      Found in src/directives/visible.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status