Sign upLogin

RubyLouvre/avalon

View on GitHub
Star
src/vmodel/Mutation.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function get has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    get() {
        if (avalon.trackingAction) {
            this.collect() //被收集
            var childOb = this.value
            if (childOb && childOb.$events) {
Severity: Minor
Found in src/vmodel/Mutation.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function set has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    set(newValue) {
        var oldValue = this.value
        if (newValue !== oldValue) {
            if (avalon.isObject(newValue)) {
                var hash = oldValue && oldValue.$hashcode
Severity: Minor
Found in src/vmodel/Mutation.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    for (var key in childOb) {
                        if (childOb.hasOwnProperty(key)) {
                            var collectIt = childOb[key]
                        }
                    }
Severity: Major
Found in src/vmodel/Mutation.js - About 45 mins to fix

    Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
    Open

    import {
    Severity: Minor
    Found in src/vmodel/Mutation.js by eslint

    For more information visit Source: http://eslint.org/docs/rules/

    There are no issues that match your filters.

    Category
    Status