RubyLouvre/avalon

View on GitHub
src/vtree/fromDOM.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function from has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

export function from(node) {
    var type = node.nodeName.toLowerCase()
    switch (type) {
        case '#text':
        case '#comment':
Severity: Minor
Found in src/vtree/fromDOM.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function from has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function from(node) {
    var type = node.nodeName.toLowerCase()
    switch (type) {
        case '#text':
        case '#comment':
Severity: Minor
Found in src/vtree/fromDOM.js - About 1 hr to fix

    Function markProps has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    function markProps(node, attrs) {
        var ret = {}
        for (var i = 0, n = attrs.length; i < n; i++) {
            var attr = attrs[i]
            if (attr.specified) {
    Severity: Minor
    Found in src/vtree/fromDOM.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if (/\S/.test(child.nodeValue)) {
                            vnode.children.push(child)
                        }
    Severity: Major
    Found in src/vtree/fromDOM.js - About 45 mins to fix

      Parsing error: 'import' and 'export' may appear only with 'sourceType: module'
      Open

      import { orphanTag } from './orphanTag'
      Severity: Minor
      Found in src/vtree/fromDOM.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status