SU-SWS/stanford_profile

View on GitHub
themes/stanford_basic/src/js/stanford_basic.behavior.js

Summary

Maintainability
C
1 day
Test Coverage

Function attach has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  attach(context, settings) {
    (function ($, once) {
      // Validate there is a skip link anchor for the main content. If not,
      // default to #page-content.
      var $mc = $('#main-content', context).length;
Severity: Major
Found in themes/stanford_basic/src/js/stanford_basic.behavior.js - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          $('.topics__collapsable-menu', context).click(function () {
            $(this).toggleClass('show');
            if ($(this).siblings('.menu').css('display') != 'none') {
              $(this).attr('aria-expanded', 'true');
            }
    Severity: Major
    Found in themes/stanford_basic/src/js/stanford_basic.behavior.js and 1 other location - About 3 hrs to fix
    themes/stanford_basic/dist/js/behaviors.js on lines 119..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 105.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          function backToTop() {
            if ($(window).scrollTop() >= ($(window).height() * 3)) {
              $('#back-to-top').fadeIn();
            } else {
              $('#back-to-top').fadeOut();
    Severity: Major
    Found in themes/stanford_basic/src/js/stanford_basic.behavior.js and 1 other location - About 2 hrs to fix
    themes/stanford_basic/dist/js/behaviors.js on lines 108..114

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 81.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

          $(once('back-to-top', '#back-to-top', context)).click((e) => {
            e.preventDefault();
            $("html, body").animate({ scrollTop: 0 }, "slow");
            $('#page-content').attr('tabIndex', '-1').focus();
          })
    Severity: Minor
    Found in themes/stanford_basic/src/js/stanford_basic.behavior.js and 1 other location - About 55 mins to fix
    themes/stanford_basic/dist/js/behaviors.js on lines 97..103

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 59.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status