Sign upLogin

SafetyCulture/safetyculture-exporter

View on GitHub
Star

Showing 6 of 70 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    drainFn := func(resp *GetFeedResponse) error {
        var rows []*TrainingCourseProgress

        if err := json.Unmarshal(resp.Data, &rows); err != nil {
            return events.NewEventErrorWithMessage(err, events.ErrorSeverityError, events.ErrorSubSystemDataIntegrity, false, "map data")
Severity: Major
Found in pkg/internal/feed/feed_training_course_progress.go and 1 other location - About 4 hrs to fix
pkg/internal/feed/feed_issue.go on lines 105..138

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 326.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    var drainFn = func(resp *GetFeedResponse) error {
        var rows []*Issue

        if err := json.Unmarshal(resp.Data, &rows); err != nil {
            return events.NewEventErrorWithMessage(err, events.ErrorSeverityError, events.ErrorSubSystemDataIntegrity, false, "map data")
Severity: Major
Found in pkg/internal/feed/feed_issue.go and 1 other location - About 4 hrs to fix
pkg/internal/feed/feed_training_course_progress.go on lines 105..137

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 326.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    drainFn := func(resp *GetFeedResponse) error {
        var rows []*Asset

        if err := json.Unmarshal(resp.Data, &rows); err != nil {
            return fmt.Errorf("map data: %w", err)
Severity: Major
Found in pkg/internal/feed/feed_asset.go and 1 other location - About 4 hrs to fix
pkg/internal/feed/feed_action_timeline_item.go on lines 98..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 314.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    drainFn := func(resp *GetFeedResponse) error {
        var rows []*ActionTimelineItem

        if err := json.Unmarshal(resp.Data, &rows); err != nil {
            return fmt.Errorf("map data: %w", err)
Severity: Major
Found in pkg/internal/feed/feed_action_timeline_item.go and 1 other location - About 4 hrs to fix
pkg/internal/feed/feed_asset.go on lines 95..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 314.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (f *ActionAssigneeFeed) writeRows(exporter Exporter, rows []*ActionAssignee) error {
    // Calculate the size of the batch we can insert into the DB at once. Column count + buffer to account for primary keys
    batchSize := exporter.ParameterLimit() / (len(f.Columns()) + 4)
    err := util.SplitSliceInBatch(batchSize, rows, func(batch []*ActionAssignee) error {
        // Delete the actions if already exists
Severity: Major
Found in pkg/internal/feed/feed_action_assignees.go and 1 other location - About 2 hrs to fix
pkg/internal/feed/feed_issue_assignee.go on lines 34..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 246.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (f *IssueAssigneeFeed) writeRows(exporter Exporter, rows []*IssueAssignee) error {
    batchSize := exporter.ParameterLimit() / (len(f.Columns()) + 4)
    err := util.SplitSliceInBatch(batchSize, rows, func(batch []*IssueAssignee) error {
        issueIDs := fn.Map(batch, func(a *IssueAssignee) string { return a.IssueID })
Severity: Major
Found in pkg/internal/feed/feed_issue_assignee.go and 1 other location - About 2 hrs to fix
pkg/internal/feed/feed_action_assignees.go on lines 83..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 246.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language