ScoLib/l5-repository

View on GitHub

Showing 22 of 34 total issues

BaseRepository has 54 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class BaseRepository implements RepositoryInterface, RepositoryCriteriaInterface
{
    use ComparesVersionsTrait;

    /**
Severity: Major
Found in src/Prettus/Repository/Eloquent/BaseRepository.php - About 7 hrs to fix

    File BaseRepository.php has 477 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    namespace Prettus\Repository\Eloquent;
    
    use Closure;
    use Exception;
    Severity: Minor
    Found in src/Prettus/Repository/Eloquent/BaseRepository.php - About 7 hrs to fix

      Method apply has 96 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function apply($model, RepositoryInterface $repository)
          {
              $fieldsSearchable = $repository->getFieldsSearchable();
              $search = $this->request->get(config('repository.criteria.params.search', 'search'), null);
              $searchFields = $this->request->get(config('repository.criteria.params.searchFields', 'searchFields'), null);
      Severity: Major
      Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 3 hrs to fix

        Function parserFieldsSearch has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function parserFieldsSearch(array $fields = [], array $searchFields = null)
            {
                if (!is_null($searchFields) && count($searchFields)) {
                    $acceptedConditions = config('repository.criteria.acceptedConditions', [
                        '=',
        Severity: Minor
        Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Generator has 22 functions (exceeds 20 allowed). Consider refactoring.
        Open

        abstract class Generator
        {
        
            /**
             * The filesystem instance.
        Severity: Minor
        Found in src/Prettus/Repository/Generators/Generator.php - About 2 hrs to fix

          Function apply has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

              public function apply($model, RepositoryInterface $repository)
              {
                  $fieldsSearchable = $repository->getFieldsSearchable();
                  $search = $this->request->get(config('repository.criteria.params.search', 'search'), null);
                  $searchFields = $this->request->get(config('repository.criteria.params.searchFields', 'searchFields'), null);
          Severity: Minor
          Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getOptions has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getOptions()
              {
                  return [
                      [
                          'fillable',
          Severity: Minor
          Found in src/Prettus/Repository/Generators/Commands/RepositoryCommand.php - About 1 hr to fix

            Method getStub has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getStub()
                {
                    $parser = $this->getNameParser();
            
                    $action = $parser->getAction();
            Severity: Minor
            Found in src/Prettus/Repository/Generators/MigrationGenerator.php - About 1 hr to fix

              Method fire has 42 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function fire()
                  {
                      $this->generators = new Collection();
              
                      $migrationGenerator = new MigrationGenerator([
              Severity: Minor
              Found in src/Prettus/Repository/Generators/Commands/RepositoryCommand.php - About 1 hr to fix

                Method getConfigGeneratorClassPath has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function getConfigGeneratorClassPath($class, $directoryPath = false)
                    {
                        switch ($class) {
                            case ('models' === $class):
                                $path = config('repository.generator.paths.models', 'Entities');
                Severity: Minor
                Found in src/Prettus/Repository/Generators/Generator.php - About 1 hr to fix

                  Function getConfigGeneratorClassPath has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getConfigGeneratorClassPath($class, $directoryPath = false)
                      {
                          switch ($class) {
                              case ('models' === $class):
                                  $path = config('repository.generator.paths.models', 'Entities');
                  Severity: Minor
                  Found in src/Prettus/Repository/Generators/Generator.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method fire has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function fire()
                      {
                  
                          if ($this->confirm('Would you like to create a Presenter? [y|N]')) {
                              $this->call('make:presenter', [
                  Severity: Minor
                  Found in src/Prettus/Repository/Generators/Commands/EntityCommand.php - About 1 hr to fix

                    Method parserFieldsSearch has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function parserFieldsSearch(array $fields = [], array $searchFields = null)
                        {
                            if (!is_null($searchFields) && count($searchFields)) {
                                $acceptedConditions = config('repository.criteria.acceptedConditions', [
                                    '=',
                    Severity: Minor
                    Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 1 hr to fix

                      Function handle has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function handle(RepositoryEventBase $event)
                          {
                              try {
                                  $cleanEnabled = config("repository.cache.clean.enabled", true);
                      
                      
                      Severity: Minor
                      Found in src/Prettus/Repository/Listeners/CleanCacheRepository.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method getOptions has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function getOptions()
                          {
                              return [
                                  [
                                      'fillable',
                      Severity: Minor
                      Found in src/Prettus/Repository/Generators/Commands/EntityCommand.php - About 1 hr to fix

                        Function validator has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function validator()
                            {
                        
                                if (isset($this->rules) && !is_null($this->rules) && is_array($this->rules) && !empty($this->rules)) {
                                    if (class_exists('Prettus\Validator\LaravelValidator')) {
                        Severity: Minor
                        Found in src/Prettus/Repository/Eloquent/BaseRepository.php - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function applyCriteria has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function applyCriteria()
                            {
                        
                                if ($this->skipCriteria === true) {
                                    return $this;
                        Severity: Minor
                        Found in src/Prettus/Repository/Eloquent/BaseRepository.php - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function parserSearchValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected function parserSearchValue($search)
                            {
                        
                                if (stripos($search, ';') || stripos($search, ':')) {
                                    $values = explode(';', $search);
                        Severity: Minor
                        Found in src/Prettus/Repository/Criteria/RequestCriteria.php - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function parserResult has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public function parserResult($result)
                            {
                                if ($this->presenter instanceof PresenterInterface) {
                                    if ($result instanceof Collection || $result instanceof LengthAwarePaginator) {
                                        $result->each(function ($model) {
                        Severity: Minor
                        Found in src/Prettus/Repository/Eloquent/BaseRepository.php - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid too many return statements within this method.
                        Open

                                return false;
                        Severity: Major
                        Found in src/Prettus/Repository/Traits/CacheableRepository.php - About 30 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language