Sign upLogin

SergiX44/XBackBone

View on GitHub
Star
src/js/app.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function publishToggle has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    publishToggle: function () {
        var id = $(this).data('id');
        var $callerButton = $(this);
        var isOutline = false;
        if ($(this).data('published')) {
Severity: Minor
Found in src/js/app.js - About 1 hr to fix

    Function saveTag has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        saveTag: function () {
        var tag = $(this).val();
        var mediaId = $(this).data('id');
        var $parent = $(this).parent();
        if (tag === '') {
    Severity: Minor
    Found in src/js/app.js - About 1 hr to fix

      Function addTag has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          addTag: function (e) {
        var $caller = $(this);
        var $newAddTag = $caller.clone()
            .click(app.addTag)
            .appendTo($caller.parent());
      Severity: Minor
      Found in src/js/app.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                if ($(this).data('published')) {
            isOutline = $callerButton.hasClass('btn-outline-warning');
            $.post(window.AppConfig.base_url + '/upload/' + id + '/unpublish', function () {
                $callerButton
                    .data('published', false)
        Severity: Major
        Found in src/js/app.js and 1 other location - About 6 hrs to fix
        src/js/app.js on lines 103..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

                } else {
            isOutline = $callerButton.hasClass('btn-outline-info');
            $.post(window.AppConfig.base_url + '/upload/' + id + '/publish', function () {
                $callerButton
                    .data('published', true)
        Severity: Major
        Found in src/js/app.js and 1 other location - About 6 hrs to fix
        src/js/app.js on lines 90..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 158.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status