Showing 34 of 73 total issues
Function findOne
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
findOne(req, res) {
const { accountNumber } = req.params;
if (/[A-Za-z]+/g.test(accountNumber)) {
return res.status(400).json({
status: 400,
Function modalOpen
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
function modalOpen(bool, action = 'undefined') {
if (bool) {
modal.style.display = 'block';
modalContent.innerHTML = '';
// Delete form
Function findByEmail
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
async findByEmail(req, res) {
try {
const user = await User.findBy('email', req.params.email, res);
Account.findBy('owner', user.rows[0].id, res)
Function findAll
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
async findAll(req, res) {
const { accountNumber } = req.params;
if (/[A-Za-z]+/g.test(accountNumber)) {
return res.status(400).json({
status: 400,
Function debitAccount
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
async debitAccount(req, res) {
const { accountNumber } = req.params;
if (/[A-Za-z]+/g.test(accountNumber)) {
return res.status(400).json({
status: 400,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function creditAccount
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
async creditAccount(req, res) {
const { accountNumber } = req.params;
if (/[A-Za-z]+/g.test(accountNumber)) {
return res.status(400).json({
status: 400,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
return res.status(500).json({ status: 500, error: `Something went wrong. Please try again - ${err}` });
Avoid too many return
statements within this function. Open
return res.status(201).json({
status: 201,
data: {
transactionId: newTransaction.rows[0].transaction_id,
accountNumber: newTransaction.rows[0].account_number,
Avoid too many return
statements within this function. Open
return res.status(401).json({
status: 401,
error: 'Unauthorized access',
});
Avoid too many return
statements within this function. Open
return res.status(401).json({
status: 401,
error: 'Unauthorized access',
});
Avoid too many return
statements within this function. Open
return res.status(500).json({ status: 500, error: `Something went wrong. Please try again - ${err}` });
Avoid too many return
statements within this function. Open
return res.status(201).json({ status: 201, data: transactions.rows });
Function findAll
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
async findAll(req, res) {
const { accountNumber } = req.params;
if (/[A-Za-z]+/g.test(accountNumber)) {
return res.status(400).json({
status: 400,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function tokenVerify
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
async tokenVerify(req, res, next) {
const token = req.headers['x-access-token'];
if (!token) {
return res.status(401).json({
status: 401,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"