Sign upLogin

Shegsdev/Banka

View on GitHub
Star
server/controllers/transactionsController.js

Summary

Maintainability
C
1 day
Test Coverage

Function findOne has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  async findOne(req, res) {
    const { transactionId } = req.params;
    if (!transactionId || !isFinite(transactionId)) {
      return res.status(400).json({ status: 400, error: 'Invalid transaction id' });
    }
Severity: Minor
Found in server/controllers/transactionsController.js - About 1 hr to fix

    Function findAll has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async findAll(req, res) {
    const { accountNumber } = req.params;
    if (/[A-Za-z]+/g.test(accountNumber)) {
      return res.status(400).json({
        status: 400,
    Severity: Minor
    Found in server/controllers/transactionsController.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

            return res.status(500).json({ status: 500, error: `Something went wrong. Please try again - ${err}` });
      Severity: Major
      Found in server/controllers/transactionsController.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return res.status(500).json({ status: 500, error: `Something went wrong. Please try again - ${err}` });
        Severity: Major
        Found in server/controllers/transactionsController.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return res.status(201).json({ status: 201, data: transactions.rows });
          Severity: Major
          Found in server/controllers/transactionsController.js - About 30 mins to fix

            Function findAll has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              async findAll(req, res) {
    const { accountNumber } = req.params;
    if (/[A-Za-z]+/g.test(accountNumber)) {
      return res.status(400).json({
        status: 400,
            Severity: Minor
            Found in server/controllers/transactionsController.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (account.rows[0].owner !== req.user.id) {
        return res.status(403).json({ status: 403, err: 'Unauthorized access' });
      }
            Severity: Major
            Found in server/controllers/transactionsController.js and 1 other location - About 1 hr to fix
            server/controllers/transactionsController.js on lines 73..75

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  if (account.rows[0].owner !== req.user.id) {
        return res.status(403).json({ status: 403, err: 'Unauthorized access' });
      }
            Severity: Major
            Found in server/controllers/transactionsController.js and 1 other location - About 1 hr to fix
            server/controllers/transactionsController.js on lines 36..38

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (account.rows.length < 1) {
        return res.status(404).json({
          status: 404,
          error: 'Account does not exist',
        });
            Severity: Major
            Found in server/controllers/transactionsController.js and 2 other locations - About 40 mins to fix
            server/controllers/auth/signupController.js on lines 39..44
            server/controllers/transactionsController.js on lines 65..70

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (transaction.rows.length < 1) {
        return res.status(404).json({
          status: 404,
          message: 'Transaction does not exist',
        });
            Severity: Major
            Found in server/controllers/transactionsController.js and 2 other locations - About 40 mins to fix
            server/controllers/auth/signupController.js on lines 39..44
            server/controllers/transactionsController.js on lines 30..35

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                try {
      const account = await Account.findBy('account_number', parseInt(accountNumber, 10), res);
      if (account.rows.length < 1) {
        return res.status(404).json({
          status: 404,
            Severity: Minor
            Found in server/controllers/transactionsController.js and 2 other locations - About 35 mins to fix
            server/controllers/accountsController.js on lines 41..59
            server/controllers/transactionsController.js on lines 63..90

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                try {
      const transaction = await Transaction.findBy('transaction_id', parseInt(transactionId, 10), res);
      if (transaction.rows.length < 1) {
        return res.status(404).json({
          status: 404,
            Severity: Minor
            Found in server/controllers/transactionsController.js and 2 other locations - About 35 mins to fix
            server/controllers/accountsController.js on lines 41..59
            server/controllers/transactionsController.js on lines 28..43

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 47.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 6 locations. Consider refactoring.
            Open

                if (/[A-Za-z]+/g.test(accountNumber)) {
      return res.status(400).json({
        status: 400,
        error: 'Invalid account number',
      });
            Severity: Major
            Found in server/controllers/transactionsController.js and 5 other locations - About 30 mins to fix
            server/controllers/accountsController.js on lines 125..130
            server/controllers/accountsController.js on lines 210..215
            server/controllers/accountsController.js on lines 269..274
            server/controllers/accountsController.js on lines 343..348
            server/controllers/accountsController.js on lines 424..429

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status